gh-69214: Fix fcntl.ioctl() request type #119498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use an 'unsigned long' instead of an 'unsigned int' for the request parameter of fcntl.ioctl() to support requests larger than UINT_MAX.
vstinner
added
needs backport to 3.12
serhiy-storchaka
approved these changes
May 24, 2024
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 24, 2024
Use an 'unsigned long' instead of an 'unsigned int' for the request parameter of fcntl.ioctl() to support requests larger than UINT_MAX. (cherry picked from commit 92fab33) Co-authored-by: Victor Stinner <vstinner@python.org>
|
Sorry, @vstinner, I could not cleanly backport this to |
|
GH-119504 is a backport of this pull request to the 3.13 branch. |
|
GH-119505 is a backport of this pull request to the 3.12 branch. |
|
Merged, thanks for the review. |
vstinner
added a commit
to vstinner/cpython
that referenced
this pull request
May 24, 2024
Use an 'unsigned long' instead of an 'unsigned int' for the request parameter of fcntl.ioctl() to support requests larger than UINT_MAX. (cherry picked from commit 92fab33)
vstinner
added a commit
that referenced
this pull request
May 24, 2024
vstinner
added a commit
to vstinner/cpython
that referenced
this pull request
Jun 1, 2024
…GH-119498) (python#119504)" This reverts commit 0bab0b3.
vstinner
added a commit
to vstinner/cpython
that referenced
this pull request
Jun 1, 2024
…GH-119498) (python#119504)" This reverts commit 0bab0b3. The change modified how negative values, like termios.TIOCSWINSZ, was treated and is actually backward incompatible.
vstinner
added a commit
to vstinner/cpython
that referenced
this pull request
Jun 1, 2024
…#119498) (python#119505)" This reverts commit 078da88. The change modified how negative values, like termios.TIOCSWINSZ, was treated and is actually backward incompatible.
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
Use an 'unsigned long' instead of an 'unsigned int' for the request parameter of fcntl.ioctl() to support requests larger than UINT_MAX.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use an 'unsigned long' instead of an 'unsigned int' for the request parameter of fcntl.ioctl() to support requests larger than UINT_MAX.