Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-117657: Avoid sem_clockwait in TSAN #119915

Merged
merged 3 commits into from
Jun 3, 2024

Conversation

colesbury
Copy link
Contributor

@colesbury colesbury commented Jun 1, 2024

The sem_clockwait function is not currently instrumented by TSan, which leads
to false positives.

@colesbury
Copy link
Contributor Author

colesbury commented Jun 1, 2024

EDIT: Needed to disable sem_clockwait. We do that in thread_pthread.h, but not in parking_lot.c.

The `sem_clockwait` function is not currently instrumented, which leads
to false positives.
@colesbury colesbury force-pushed the gh-117657-parking-lot-suppressions branch from 96bb646 to 11936b3 Compare June 1, 2024 19:11
@colesbury colesbury changed the title gh-117657: Remove parking lot related TSAN suppressions gh-117657: Avoid sem_clockwait in TSAN Jun 1, 2024
@colesbury colesbury marked this pull request as ready for review June 1, 2024 19:45
@colesbury colesbury requested a review from DinoV June 3, 2024 16:16
Copy link
Contributor

@DinoV DinoV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@colesbury colesbury merged commit 41c1cef into python:main Jun 3, 2024
34 checks passed
@miss-islington-app
Copy link

Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@colesbury colesbury deleted the gh-117657-parking-lot-suppressions branch June 3, 2024 17:42
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 3, 2024
The `sem_clockwait` function is not currently instrumented, which leads
to false positives.
(cherry picked from commit 41c1cef)

Co-authored-by: Sam Gross <colesbury@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Jun 3, 2024

GH-119992 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jun 3, 2024
colesbury added a commit that referenced this pull request Jun 3, 2024
The `sem_clockwait` function is not currently instrumented, which leads
to false positives.
(cherry picked from commit 41c1cef)

Co-authored-by: Sam Gross <colesbury@gmail.com>
mliezun pushed a commit to mliezun/cpython that referenced this pull request Jun 3, 2024
The `sem_clockwait` function is not currently instrumented, which leads
to false positives.
barneygale pushed a commit to barneygale/cpython that referenced this pull request Jun 5, 2024
The `sem_clockwait` function is not currently instrumented, which leads
to false positives.
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
The `sem_clockwait` function is not currently instrumented, which leads
to false positives.
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
The `sem_clockwait` function is not currently instrumented, which leads
to false positives.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants