-
-
Notifications
You must be signed in to change notification settings - Fork 30.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-117657: Avoid sem_clockwait
in TSAN
#119915
Merged
colesbury
merged 3 commits into
python:main
from
colesbury:gh-117657-parking-lot-suppressions
Jun 3, 2024
Merged
gh-117657: Avoid sem_clockwait
in TSAN
#119915
colesbury
merged 3 commits into
python:main
from
colesbury:gh-117657-parking-lot-suppressions
Jun 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colesbury
added
skip news
topic-free-threading
needs backport to 3.13
bugs and security fixes
labels
Jun 1, 2024
EDIT: Needed to disable |
The `sem_clockwait` function is not currently instrumented, which leads to false positives.
colesbury
force-pushed
the
gh-117657-parking-lot-suppressions
branch
from
June 1, 2024 19:11
96bb646
to
11936b3
Compare
colesbury
changed the title
gh-117657: Remove parking lot related TSAN suppressions
gh-117657: Avoid Jun 1, 2024
sem_clockwait
in TSAN
DinoV
reviewed
Jun 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 3, 2024
The `sem_clockwait` function is not currently instrumented, which leads to false positives. (cherry picked from commit 41c1cef) Co-authored-by: Sam Gross <colesbury@gmail.com>
GH-119992 is a backport of this pull request to the 3.13 branch. |
colesbury
added a commit
that referenced
this pull request
Jun 3, 2024
mliezun
pushed a commit
to mliezun/cpython
that referenced
this pull request
Jun 3, 2024
The `sem_clockwait` function is not currently instrumented, which leads to false positives.
barneygale
pushed a commit
to barneygale/cpython
that referenced
this pull request
Jun 5, 2024
The `sem_clockwait` function is not currently instrumented, which leads to false positives.
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
The `sem_clockwait` function is not currently instrumented, which leads to false positives.
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
The `sem_clockwait` function is not currently instrumented, which leads to false positives.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
sem_clockwait
function is not currently instrumented by TSan, which leadsto false positives.