Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-117657: Fix TSAN reported race in _PyEval_IsGILEnabled. #119921

Merged
merged 1 commit into from
Jun 2, 2024

Conversation

colesbury
Copy link
Contributor

@colesbury colesbury commented Jun 1, 2024

The GIL may be disabled concurrently with this call so we need to use a relaxed atomic load.

The GIL may be disabled concurrently with this call so we need to use a
relaxed atomic load.
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_PyEval_IsGILEnabled is called at free-threaded build only so using atomic operation directly looks reasonable.

LGTM

@colesbury colesbury merged commit f3b89a6 into python:main Jun 2, 2024
40 checks passed
@miss-islington-app
Copy link

Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@colesbury colesbury deleted the gh-117657-is-gil-enabled branch June 2, 2024 14:19
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 2, 2024
…ythonGH-119921)

The GIL may be disabled concurrently with this call so we need to use a
relaxed atomic load.
(cherry picked from commit f3b89a6)

Co-authored-by: Sam Gross <colesbury@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Jun 2, 2024

GH-119939 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jun 2, 2024
colesbury added a commit that referenced this pull request Jun 2, 2024
…H-119921) (#119939)

The GIL may be disabled concurrently with this call so we need to use a
relaxed atomic load.
(cherry picked from commit f3b89a6)

Co-authored-by: Sam Gross <colesbury@gmail.com>
mliezun pushed a commit to mliezun/cpython that referenced this pull request Jun 3, 2024
…ython#119921)

The GIL may be disabled concurrently with this call so we need to use a
relaxed atomic load.
barneygale pushed a commit to barneygale/cpython that referenced this pull request Jun 5, 2024
…ython#119921)

The GIL may be disabled concurrently with this call so we need to use a
relaxed atomic load.
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
…ython#119921)

The GIL may be disabled concurrently with this call so we need to use a
relaxed atomic load.
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
…ython#119921)

The GIL may be disabled concurrently with this call so we need to use a
relaxed atomic load.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants