Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.13] gh-118596: Add thread-safety clarifications to the SSLContext documentation (GH-118597) #120595

Merged
merged 1 commit into from
Jun 16, 2024

Commits on Jun 16, 2024

  1. pythongh-118596: Add thread-safety clarifications to the SSLContext d…

    …ocumentation (pythonGH-118597)
    
    Add thread-safety clarifications to the SSLContext documentation. Per the issue:
    
    This issue has also come up [here](psf/requests#6667) where the matter was clarified by @tiran in [this comment](psf/requests#6667):
    > `SSLContext` is designed to be shared and used for multiple connections. It is thread safe as long as you don't reconfigure it once it is used by a connection. Adding new certs to the internal trust store is fine, but changing ciphers, verification settings, or mTLS certs can lead to surprising behavior. The problem is unrelated to threads and can even occur in a single-threaded program.
    (cherry picked from commit 4f59f86)
    
    Co-authored-by: mm-matthias <43849132+mm-matthias@users.noreply.github.com>
    mm-matthias authored and miss-islington committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    07ba4c4 View commit details
    Browse the repository at this point in the history