gh-120831: Increase the default minimum supported iOS version to 13.0 #121250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freakboy3742
added
3.13
|
!buildbot iOS |
|
🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 20209cd 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
|
!buildbot iOS |
|
🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 20209cd 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
|
The new buildbot configuration has been deployed; this build shows an auto detected iOS 13 minimum, and no build warnings (compared to the previous PR build, which shows 2 warnings associated with the SQLite issue). |
erlend-aasland
approved these changes
Jul 2, 2024
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
|
!buildbot iOS |
ned-deily
approved these changes
Jul 11, 2024
|
!buildbot iOS |
1 similar comment
|
!buildbot iOS |
|
Found how I broke it... |
|
!buildbot iOS |
|
!buildbot iOS |
|
🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit cbd760e 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
|
Thanks @freakboy3742 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 16, 2024
…o 13.0 (pythonGH-121250) Increases the default minimum iOS version to 13.0. (cherry picked from commit 7e91e0d) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com> Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
|
GH-121833 is a backport of this pull request to the 3.13 branch. |
|
For posterity - merged despite the CI failures. The CI failures are due to #121832; local testing and inspection of the CI logs demonstrates that the new minimum version is being applied. |
freakboy3742
added a commit
that referenced
this pull request
Jul 16, 2024
…to 13.0 (GH-121250) (#121833) gh-120831: Increase the default minimum supported iOS version to 13.0 (GH-121250) Increases the default minimum iOS version to 13.0. (cherry picked from commit 7e91e0d) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com> Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
…o 13.0 (python#121250) Increases the default minimum iOS version to 13.0. Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Aug 5, 2024
…rsion to 13.0 (python#121250) Increases the default minimum iOS version to 13.0. Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Aug 5, 2024
…rsion to 13.0 (python#121250) Increases the default minimum iOS version to 13.0. Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Aug 5, 2024
…rsion to 13.0 (python#121250) Increases the default minimum iOS version to 13.0. Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Aug 5, 2024
…sion to 13.0 (python#121250) Increases the default minimum iOS version to 13.0. Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Sep 6, 2024
…rsion to 13.0 (python#121250) Increases the default minimum iOS version to 13.0. Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Sep 9, 2024
…rsion to 13.0 (python#121250) Increases the default minimum iOS version to 13.0. Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Sep 9, 2024
…rsion to 13.0 (python#121250) Increases the default minimum iOS version to 13.0. Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Sep 9, 2024
…rsion to 13.0 (python#121250) Increases the default minimum iOS version to 13.0. Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Sep 9, 2024
…sion to 13.0 (python#121250) Increases the default minimum iOS version to 13.0. Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Oct 9, 2024
…rsion to 13.0 (python#121250) Increases the default minimum iOS version to 13.0. Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps the default minimum iOS version from 12.0 to 13.0.
As discussed on #120831, the previous default value of 12.0 worked successfully at runtime, but raised a compilation warning about the usage of an SQLite API that wasn't added until iOS 13.0. Although protection exists in the code to prevent any runtime problem, avoiding the compilation warning was judged to be more important.
The usage of iOS 12 is estimated to be less that 0.5% of the total iOS install base, so the impact on the user base is minor. It's also only a default version; it's possible to manually configure any minimum version at compile time.
In addition to increasing the default minimum version, this PR modifies the logging generated by the configure script to be more explicit about the iOS deployment target (aka minimum version) that will be used. It also adds usage documentation about the default iOS supported version.
The buildbot will still generate the warning because it the iOS buildbot configuration currently hard-codes the 12.0 minimum supported version. I'll push an update for the buildbot configuration shortly.
Fixes #120831.
enclose 'sqlite3_create_window_function' in a __builtin_available check to silence this warning#120831📚 Documentation preview 📚: https://cpython-previews--121250.org.readthedocs.build/