gh-121160: Add a test for readline.set_history_length #121326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
encukou
added
skip news
🔨 test-with-buildbots
bedevere-bot
removed
the
🔨 test-with-buildbots
encukou
added
the
🔨 test-with-buildbots
bedevere-bot
removed
the
🔨 test-with-buildbots
encukou
added
needs backport to 3.12
|
Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 16, 2024
…onGH-121326) (cherry picked from commit 263c7e6) Co-authored-by: Petr Viktorin <encukou@gmail.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 16, 2024
…onGH-121326) (cherry picked from commit 263c7e6) Co-authored-by: Petr Viktorin <encukou@gmail.com>
|
GH-121856 is a backport of this pull request to the 3.13 branch. |
|
GH-121857 is a backport of this pull request to the 3.12 branch. |
encukou
added a commit
that referenced
this pull request
Jul 16, 2024
encukou
added a commit
that referenced
this pull request
Jul 16, 2024
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I could not reproduce the reported issue, but, I didn't try very hard to test on various readline libraries.
Regardless,
set_history_lengthwas missing a test. This PR should show if the error exists on CPython's buildbot platforms. (And if it doesn't and it's merged, it should fail for redistributors with who build with different libraries.)My copy of readline (Fedora 40) reports an extra history element after reading the file; IMO that's not the end of the world.
readline.set_history_lengthcorrupts history files when used in a libedit build #121160