-
-
Notifications
You must be signed in to change notification settings - Fork 30.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-117482: Fix Builtin Types Slot Wrappers When Embedded #121636
gh-117482: Fix Builtin Types Slot Wrappers When Embedded #121636
Conversation
I feel like while we are at it, properly implementing a full cleanup of the runtime state as mentioned in the |
Yep. It's on my TODO list. 😄 |
🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 8520cfc 🤖 If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
!buildbot iOS |
🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 8520cfc 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
I'm going to go with gh-122865. We can circle back to this later. |
While gh-121602 solved most of the problem, it did not resolve the case where the runtime gets re-initialized. In that case, we end up in the same situation as before, where the inherited "tp" slots are set, which makes
add_operators()
do the wrong thing. We fix that by resetting the static type to the preserved values during finalization. We also make sure the type substructs are preserved.(Given that this fix is for a more unlikely case, I'm inclined to not backport this to 3.12.)
int.__str__
behaviour inside sub-interpreters #117482