-
-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-121784: Generate an error during code gen if a variable is marked unused
, but is used and thus cached in a prior uop.
#121788
GH-121784: Generate an error during code gen if a variable is marked unused
, but is used and thus cached in a prior uop.
#121788
Conversation
I'll review after tests pass. |
This ended up being rather involved. The explicit stores to the stack were needed not just because the code generator failed to track values across uops with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment, else LGTM. I've taken a look at the generated code for tier 1 as well.
unused
#121784