Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-121784: Generate an error during code gen if a variable is marked unused, but is used and thus cached in a prior uop. #121788

Merged
merged 14 commits into from
Jul 18, 2024

Conversation

markshannon
Copy link
Member

@markshannon markshannon commented Jul 15, 2024

@Fidget-Spinner
Copy link
Member

I'll review after tests pass.

@markshannon
Copy link
Member Author

This ended up being rather involved. The explicit stores to the stack were needed not just because the code generator failed to track values across uops with unused operands, but because the stack needs to be flushed to memory, in case of a de-opt.
I've fixed that by adding support for an explicit flush operation in macros.

Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, else LGTM. I've taken a look at the generated code for tier 1 as well.

Tools/cases_generator/analyzer.py Outdated Show resolved Hide resolved
@markshannon markshannon merged commit 3eacfc1 into python:main Jul 18, 2024
64 checks passed
@markshannon markshannon deleted the error-on-unused-cached branch August 6, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants