Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-121834: Improve complex C-API docs #121835

Merged
merged 6 commits into from
Jul 17, 2024
Merged

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Jul 16, 2024

cc @skirpichev

I unified exception messages for NULL and -1.0 cases separatelly.


📚 Documentation preview 📚: https://cpython-previews--121835.org.readthedocs.build/

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news labels Jul 16, 2024
@sobolevn sobolevn added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Jul 16, 2024
Copy link
Contributor

@skirpichev skirpichev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Doc/c-api/complex.rst Outdated Show resolved Hide resolved
sobolevn and others added 3 commits July 16, 2024 10:26
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
Doc/c-api/complex.rst Outdated Show resolved Hide resolved
@sobolevn
Copy link
Member Author

The build failure is not related, see #121766

@sobolevn
Copy link
Member Author

This looks fine:
Снимок экрана 2024-07-16 в 11 11 56

Thanks everyone!

Doc/c-api/complex.rst Outdated Show resolved Hide resolved
Doc/c-api/complex.rst Outdated Show resolved Hide resolved
Co-authored-by: Petr Viktorin <encukou@gmail.com>
@sobolevn sobolevn merged commit 72dccd6 into python:main Jul 17, 2024
24 checks passed
@miss-islington-app
Copy link

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 17, 2024
(cherry picked from commit 72dccd6)

Co-authored-by: sobolevn <mail@sobolevn.me>
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
Co-authored-by: Petr Viktorin <encukou@gmail.com>
@sobolevn
Copy link
Member Author

Thanks everyone!

@miss-islington-app
Copy link

Sorry, @sobolevn, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 72dccd60735b597e99c007a7b69210763a746877 3.12

@bedevere-app
Copy link

bedevere-app bot commented Jul 17, 2024

GH-121895 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 17, 2024
@sobolevn
Copy link
Member Author

I will backport this to 3.12 manually.

sobolevn added a commit to sobolevn/cpython that referenced this pull request Jul 17, 2024
(cherry picked from commit 72dccd6)

Co-authored-by: sobolevn <mail@sobolevn.me>
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
Co-authored-by: Petr Viktorin <encukou@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Jul 17, 2024

GH-121897 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Jul 17, 2024
sobolevn added a commit that referenced this pull request Jul 17, 2024
gh-121834: Improve `complex` C-API docs (GH-121835)
(cherry picked from commit 72dccd6)

Co-authored-by: sobolevn <mail@sobolevn.me>
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
Co-authored-by: Petr Viktorin <encukou@gmail.com>
sobolevn added a commit that referenced this pull request Jul 17, 2024
* [3.12] gh-121834: Improve `complex` C-API docs (GH-121835)
(cherry picked from commit 72dccd6)

Co-authored-by: sobolevn <mail@sobolevn.me>
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
Co-authored-by: Petr Viktorin <encukou@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants