-
-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-121834: Improve complex
C-API docs
#121835
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
The build failure is not related, see #121766 |
Co-authored-by: Petr Viktorin <encukou@gmail.com>
Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
(cherry picked from commit 72dccd6) Co-authored-by: sobolevn <mail@sobolevn.me> Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com> Co-authored-by: Petr Viktorin <encukou@gmail.com>
Thanks everyone! |
Sorry, @sobolevn, I could not cleanly backport this to
|
GH-121895 is a backport of this pull request to the 3.13 branch. |
I will backport this to 3.12 manually. |
(cherry picked from commit 72dccd6) Co-authored-by: sobolevn <mail@sobolevn.me> Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com> Co-authored-by: Petr Viktorin <encukou@gmail.com>
GH-121897 is a backport of this pull request to the 3.12 branch. |
cc @skirpichev
I unified exception messages for
NULL
and-1.0
cases separatelly.complex
C-API error descriptions #121834📚 Documentation preview 📚: https://cpython-previews--121835.org.readthedocs.build/