gh-117482: Simplify the Fix For Builtin Types Slot Wrappers #121882
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericsnowcurrently
added
skip news
needs backport to 3.12
|
!buildbot iOS |
|
🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit ecb14da 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
ericsnowcurrently
changed the title
|
The commit log churn in main isn't worth it, so I'll focus on applying this to just 3.13 and 3.12. |
ericsnowcurrently
deleted the
simplify-builtin-static-type-add-operators-main
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In gh-121602, I applied a fix to a builtin types initialization bug. That fix made sense in the context of some broader future changes, but introduced a little bit of extra complexity. There are a few tricky spots to iron out so the simplest thing to do in the short term is to revert that change and replace it with one that is more focused.
That's this PR. It's essentially the implementation of an idea that @markshannon pointed out to me. Note that this change would be simpler if we didn't have to deal with compatibility for builtin types that explicitly inherit different slots.
int.__str__behaviour inside sub-interpreters #117482