Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document mimetypes.MimeTypes.add_type() #122301

Merged
merged 5 commits into from
Jul 26, 2024
Merged

Document mimetypes.MimeTypes.add_type() #122301

merged 5 commits into from
Jul 26, 2024

Conversation

negativenagesh
Copy link
Contributor

@negativenagesh negativenagesh commented Jul 26, 2024 •
edited
Loading

@negativenagesh negativenagesh requested a review from a team as a code owner July 26, 2024 05:20
@cpython-cla-bot CPython CLA Bot
Copy link

cpython-cla-bot bot commented Jul 26, 2024 •
edited
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting review labels Jul 26, 2024
@negativenagesh negativenagesh changed the title 1. In "github\cpython\Doc\library\mimetypes.rst" successfully added addtype method (MimeTypes.add_type) under MimeTypes Objects adding add_type method Jul 26, 2024
AA-Turner
AA-Turner approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified identical to https://docs.python.org/dev/library/mimetypes.html#mimetypes.add_type

A

@AA-Turner AA-Turner changed the title adding add_type method Document MimeTypes.add_type() Jul 26, 2024
@AA-Turner AA-Turner added skip issue needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Jul 26, 2024
AA-Turner
AA-Turner requested changes Jul 26, 2024
View reviewed changes
Doc/library/mimetypes.rst Outdated Show resolved Hide resolved
Doc/library/mimetypes.rst Outdated Show resolved Hide resolved
@bedevere-app
Copy link

bedevere-app bot commented Jul 26, 2024

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@AA-Turner AA-Turner changed the title Document MimeTypes.add_type() Document mimetypes.MimeTypes.add_type() Jul 26, 2024
@AA-Turner AA-Turner enabled auto-merge (squash) July 26, 2024 21:43
@AA-Turner AA-Turner disabled auto-merge July 26, 2024 21:45
@AA-Turner AA-Turner enabled auto-merge (squash) July 26, 2024 21:45
@AA-Turner AA-Turner merged commit d52726c into python:main Jul 26, 2024
23 checks passed
@miss-islington-app
Copy link

Thanks @negativenagesh for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 26, 2024
@negativenagesh @AA-Turner @miss-islington
Document mimetypes.MimeTypes.add_type() (pythonGH-122301)
c4126b1 
(cherry picked from commit d52726c)

Co-authored-by: Subrahmanya Gaonkar <148525245+negativenagesh@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Jul 26, 2024

GH-122328 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 26, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 26, 2024
@negativenagesh @AA-Turner @miss-islington
Document mimetypes.MimeTypes.add_type() (pythonGH-122301)
0fef7d1 
(cherry picked from commit d52726c)

Co-authored-by: Subrahmanya Gaonkar <148525245+negativenagesh@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Jul 26, 2024

GH-122329 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Jul 26, 2024
AA-Turner added a commit that referenced this pull request Jul 26, 2024
@miss-islington @negativenagesh @AA-Turner
[3.12] Document mimetypes.MimeTypes.add_type() (GH-122301) (#122329)
d4ca183 
Document ``mimetypes.MimeTypes.add_type()`` (GH-122301)
(cherry picked from commit d52726c)

Co-authored-by: Subrahmanya Gaonkar <148525245+negativenagesh@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
AA-Turner added a commit that referenced this pull request Jul 26, 2024
@miss-islington @negativenagesh @AA-Turner
[3.13] Document mimetypes.MimeTypes.add_type() (GH-122301) (#122328)
4fa46cf 
Document ``mimetypes.MimeTypes.add_type()`` (GH-122301)
(cherry picked from commit d52726c)

Co-authored-by: Subrahmanya Gaonkar <148525245+negativenagesh@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@stinovlas stinovlas mentioned this pull request Aug 22, 2024
Closed
@hugovk hugovk mentioned this pull request Nov 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AA-Turner AA-Turner AA-Turner approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@negativenagesh @AA-Turner