Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-122402: Eliminate conflicts between build variants installed to a common prefix #122403

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

ned-deily
Copy link
Member

@ned-deily ned-deily commented Jul 29, 2024

When using configure-based (i.e. non-Windows) Python installations, if more than one build variant is installed to the same prefix, some files in the bin and lib/pkgconfig directories currently are installed with the same name by each variant, with potentially unpredictable and undesired results.

See issue #122402 for background and details.

This PR addresses identified issues for installs of non-default build variants {v}), i.e debug (d), free-threading (t), and free-threading debug (td), by changing:

  • make altinstall for d, t, and td variants:
    • do not install python3.x and python3.x-config
    • install idle3.x, pydoc3.x as idle3.x{v}, pydoc3.x{v}
    • do not install lib/pkgconfig python-3.x-embed.pc and python-3.x.pc
  • make install for d, t, and td variants:
    • install python3, python3-config as python3{v}, python3{v}-config
    • install idle3, pydoc3 as idle3{v}, pydoc3{v}
    • install lib/pkgconfig python3-embed.pc, python.pc as python3{v}-embed.pc, python3.pc

The PR also eliminates similar conflicts in the Unix Tools symlinks installed for macOS frameworks builds.

@ned-deily ned-deily added build The build process and cross-build topic-installation 3.13 bugs and security fixes topic-free-threading 3.14 new features, bugs and security fixes needs backport to 3.13 bugs and security fixes labels Jul 29, 2024
@ned-deily ned-deily requested review from warsaw, colesbury and Yhg1s July 29, 2024 15:06
@ned-deily ned-deily requested review from a team and erlend-aasland as code owners July 29, 2024 15:06
@ned-deily ned-deily added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 29, 2024
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @ned-deily for commit e39646c 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.13 bugs and security fixes 3.14 new features, bugs and security fixes awaiting core review build The build process and cross-build needs backport to 3.13 bugs and security fixes topic-free-threading topic-installation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants