gh-123085: Fix issue in inferred caller when resources package has no source #123102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaraco
changed the title
jaraco
added
needs backport to 3.12
jaraco
requested review from
warsaw,
FFY00,
brettcannon,
ericsnowcurrently,
ncoghlan and
erlend-aasland
as code owners
jaraco
force-pushed
the
gh-123085/inferred-compiled
branch
from
e4bfe86 to
b6bd51d
Compare
1 task
…has no source. From importlib_resources 6.4.3 (python/importlib_resources#314).
jaraco
force-pushed
the
gh-123085/inferred-compiled
branch
from
b6bd51d to
097b06c
Compare
|
I'm proceeding with a merge to unblock #124018. |
|
Thanks @jaraco for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
|
Sorry, @jaraco, I could not cleanly backport this to |
|
Sorry, @jaraco, I could not cleanly backport this to |
|
The backport to 3.13 is blocked by: |
jaraco
added a commit
to jaraco/cpython
that referenced
this pull request
Sep 12, 2024
…ackage has no source (pythonGH-123102) pythongh-123085: Fix issue in inferred caller when resources package has no source. From importlib_resources 6.4.3 (python/importlib_resourcesGH-314). (cherry picked from commit a53812d) Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
|
GH-124021 is a backport of this pull request to the 3.12 branch. |
jaraco
added a commit
to jaraco/cpython
that referenced
this pull request
Sep 12, 2024
…ckage has no source (pythonGH-123102)
1 task
|
GH-124024 is a backport of this pull request to the 3.13 branch. |
jaraco
added a commit
that referenced
this pull request
Jan 5, 2025
… has no source (GH-123102) (#124021) gh-123085: Fix issue in inferred caller when resources package has no source. From importlib_resources 6.4.3 (python/importlib_resourcesGH-314). (cherry picked from commit a53812d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Await gh-121735: Fix module-adjacent references in zip files #123037
importlib.resources.files() doesn't work correctly when importlib library is compiled #123085: Fix issue in inferred caller when resources package has no source.