GH-119518: Stop interning strings in pathlib #123356
Merged
+3
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
sys.intern(str(x))
calls when normalizing a path in pathlib. This speeds upstr(Path('foo/bar'))
by about 10%.As mentioned in the issue, I've never been able to establish if/when string interning is useful in pathlib, nor that we're using it in the best way. It feels negligent to leave it in the code.