gh-123440: Improve error message for except as
used with not a name
#123442
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main idea is that this rule is the last in chain. So, any valid cases with
NAME
expressions are already matched. So, I guess it is safe to use'except' expression 'as' a=expression
later on.I tried to use a single rule in
invalid_except_stmt
like:but since it is used for both
except_block
andexcept_star_block
- this produced an incorrect result.except a as b.c:
case #123440