gh-123881: make compiler add the .generic_base base class without constructing AST nodes

[iritkatriel]

Fixes #123881.

• Issue: Compiler should not need to know how to construct AST nodes #123881

[JelleZijlstra]

I feel this is worse, since it makes the AST returned by ast.parse different from what users actually see. Users dealing with the AST will have to learn about this new oddity.

The issue this is attached to says the compiler modifies the AST, but it doesn't; it creates a new ASDL seq and inserts an extra entry into it. The original AST is not modified.

[bedevere-app]

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

[iritkatriel]

it makes the AST returned by ast.parse different from what users actually see.

This is true anyway, the AST currently gives no indication that class C[T]: pass has a base class.

[JelleZijlstra]

If it's important to you to remove the code creating a fake AST node here, you could instead add an extra argument to codegen_call_helper that is usually NULL and maps to an extra argument to add at the end of the list. I think I did that initially while working on PEP 695, but it seemed worse than creating a new virtual asdl_seq as the current code does. (Possibly you were involved in discussing that in person, don't remember exactly.)

But I'd like to keep the extra base class as an implementation detail in the compiler, not something that gets exposed in the AST layer.

[iritkatriel]

Ok, I'll try something like that, should be quite simple.
It's possible I was involved in the discussion at the time, I don't remember the details.

I think it would be better if the compiler didn't need to know how to create AST nodes. (I take your point about it not modifying the AST, I'll correct the wording in the issue)

[JelleZijlstra]

I found back the discussion from last time: #103764 (comment).

[iritkatriel]

I have made the requested changes; please review again.

[bedevere-app]

Thanks for making the requested changes!

@JelleZijlstra: please review the changes made to this pull request.