Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-36346: Prepare for removing the legacy Unicode C API. #12409

Closed
wants to merge 32 commits into from
Closed

bpo-36346: Prepare for removing the legacy Unicode C API. #12409

wants to merge 32 commits into from

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Mar 18, 2019 •
edited by bedevere-bot
Loading

Add two compile time options: HAVE_UNICODE_WCHAR_CACHE and
USE_UNICODE_WCHAR_CACHE.

USE_UNICODE_WCHAR_CACHE makes the interpreter not using the
wchar_t cache and the legacy Unicode C API.

HAVE_UNICODE_WCHAR_CACHE removes the wchar_t cache and the
legacy Unicode C API that depends on it.

https://bugs.python.org/issue36346

@serhiy-storchaka
bpo-36346: Prepare for removing the legacy Unicode C API.
699e616 
Add two compile time options: HAVE_UNICODE_WCHAR_CACHE and
USE_UNICODE_WCHAR_CACHE.

USE_UNICODE_WCHAR_CACHE makes the interpreter not using the
wchar_t cache and the legacy Unicode C API.

HAVE_UNICODE_WCHAR_CACHE removes the wchar_t cache and the
legacy Unicode C API that depends on it.
@serhiy-storchaka serhiy-storchaka requested review from rhettinger, skrah and a team as code owners March 18, 2019 14:27
scoder
scoder reviewed Mar 18, 2019
View reviewed changes
Copy link
Contributor

@scoder scoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that's a lot of code that will eventually be removed here. Nice!

Modules/_ctypes/callproc.c Outdated Show resolved Hide resolved
Modules/_testcapimodule.c Outdated Show resolved Hide resolved
Modules/posixmodule.c Outdated Show resolved Hide resolved
@methane
Copy link
Member

methane commented Jun 17, 2020

@serhiy-storchaka Would you split this pull request?
clinic should be updated before adding DeprecationWarning in PyArg_Parse*.

@serhiy-storchaka
Copy link
Member Author

@serhiy-storchaka Would you split this pull request?
clinic should be updated before adding DeprecationWarning in PyArg_Parse*.

#21223

@iritkatriel
Copy link
Member

https://bugs.python.org/issue36346 is closed. What is the status of this PR?

@rhettinger rhettinger removed request for rhettinger and skrah May 3, 2022 06:23
@serhiy-storchaka serhiy-storchaka mentioned this pull request May 11, 2022
Merged
@serhiy-storchaka
Copy link
Member Author

No longer actual after merging #92537.

@serhiy-storchaka serhiy-storchaka deleted the disable-wchar-cache branch May 12, 2022 11:30
@bedevere-bot bedevere-bot mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scoder scoder scoder left review comments

@methane methane methane left review comments

@blesnatalman blesnatalman blesnatalman approved these changes

Assignees
No one assigned
Labels
awaiting core review DO-NOT-MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@serhiy-storchaka @methane @iritkatriel @scoder @blesnatalman @the-knights-who-say-ni @bedevere-bot