-
-
Notifications
You must be signed in to change notification settings - Fork 30.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-124652: partialmethod simplifications #124788
Open
dg-pb
wants to merge
13
commits into
python:main
Choose a base branch
from
dg-pb:gh-124652-partialmethod
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+224
−205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasr8
reviewed
Sep 30, 2024
dg-pb
force-pushed
the
gh-124652-partialmethod
branch
from
October 6, 2024 16:56
a04c14f
to
d217592
Compare
Removed keyword Placeholder restriction from this and will issue a separate PR after. Felt like too much is packed into 1 PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3 Parts:
partial
: allowing trailing placeholders1.1. +some performance benefits for
partial.__new__
due to this changepartialmethod
simplifications1. Allowing trailing
Placeholder
sSo, I considered automatic trimming of trailing
Placeholder
s instead of forbidding such. However it didn't sit well with me.So I thought this over. So not having trailing
Placeholders
works well, however both approaches of achieving this have flaws:a) Forbidding them - results in unexpected errors for the user.
b) Trimming automatically - obfuscates inner workings and can be confusing.
Furthermore, it sometimes could be desired to have a trailing
Placeholder
to convert argument to positional only.So I think it would be best not to have this restriction at all. This makes things more explicit and predictable. E.g. both would work:
And as expected,
self
ofp1
can be both positional or keyword, whileself
ofp2
becomes restricted to positional only.Desired behaviour of
partialmethod
is achieved by appropriate delivery ofargs
. Which stays as it was before - if no positionals providedself
argument type is unaffected, while ifargs
are provided thenself
becomes positional only.2.1. +
partial.__new__
performance benefitsSlightly faster for both cases (with and without Placeholders) when merging args of previous
partial
with new args.This also simplifies code by not having to do error checks or trimming routines. While existing functionality handles trailing placeholders as it is (except minor Fast Path fix in C).
2.
partialmethod
simplificationspartial
(makes use ofpartial
instead of containing any complexities of partial)inspect
partial
objects)partialmethod
Benchmarks:Setup
functools.partialmethod
simplification #124652