Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-111178: Fix function signatures in setobject.c #124888

Merged
merged 2 commits into from
Oct 2, 2024
Merged

gh-111178: Fix function signatures in setobject.c #124888

merged 2 commits into from
Oct 2, 2024

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Oct 2, 2024 •
edited by bedevere-app bot
Loading

@vstinner vstinner requested a review from rhettinger as a code owner October 2, 2024 12:05
@bedevere-app bedevere-app bot mentioned this pull request Oct 2, 2024
Open
@vstinner
Copy link
Member Author

vstinner commented Oct 2, 2024

I didn't fix the warning on the signature generated by Argument Clinic:

Python/generated_cases.c.h:2420:35: runtime error: call to function set_pop through pointer to incorrect function type 'struct _object *(*)(struct _object *, struct _object *)'
/home/vstinner/python/main/Objects/clinic/setobject.c.h:24: note: set_pop defined here

@vstinner vstinner merged commit 9132148 into python:main Oct 2, 2024
35 checks passed
@vstinner vstinner deleted the ubsan_set branch October 2, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vstinner