gh-124917: Allow keyword args to os.path.exists/lexists on Windows #124918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelleZijlstra
changed the title
|
Thanks, I didn't feel it was worth the effort to create a PR myself. I hope that was the last thing I broke in a PR. :) |
|
This also needs a back port to 3.12... see #119381. |
erlend-aasland
approved these changes
Oct 11, 2024
This comment was marked as outdated.
This comment was marked as outdated.
|
Sorry, @JelleZijlstra, I could not cleanly backport this to |
|
Sorry, @JelleZijlstra, I could not cleanly backport this to |
JelleZijlstra
added a commit
to JelleZijlstra/cpython
that referenced
this pull request
Oct 11, 2024
…on Windows (pythonGH-124918) (cherry picked from commit cc2938a) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
|
GH-125332 is a backport of this pull request to the 3.13 branch. |
JelleZijlstra
added a commit
to JelleZijlstra/cpython
that referenced
this pull request
Oct 11, 2024
…on Windows (pythonGH-124918) (cherry picked from commit cc2938a) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
|
GH-125334 is a backport of this pull request to the 3.12 branch. |
JelleZijlstra
added a commit
that referenced
this pull request
Oct 11, 2024
JelleZijlstra
added a commit
that referenced
this pull request
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
os.path.existsandlexistsno longer allow a keyword argument on Windows #124917