-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-115145: Update documentation about PyThreadState_DeleteCurrent
#124920
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The GIL must be held, it's checked by:
|
Thanks @corona10 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
…rent`` (pythongh-124920) (cherry picked from commit 9eeb21b) Co-authored-by: Donghee Na <donghee.na@python.org>
…rent`` (pythongh-124920) (cherry picked from commit 9eeb21b) Co-authored-by: Donghee Na <donghee.na@python.org>
GH-124930 is a backport of this pull request to the 3.13 branch. |
GH-124931 is a backport of this pull request to the 3.12 branch. |
Can we have another look at this?
To me this implies that the GIL must be held for |
I agree that "Like PyThreadState_Delete()" is wrong and should be removed. @corona10: Do you want to propose a patch for this? |
Yeah I will send the patch |
PyThreadState_DeleteCurrent
documentation incorrect #115145📚 Documentation preview 📚: https://cpython-previews--124920.org.readthedocs.build/