gh-112088: aclocal version is updated to 1.16.5 in docs #125457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efimov-mikhail
requested review from
erlend-aasland and
corona10
as code owners
bedevere-app
bot
added
docs
vstinner
reviewed
Oct 14, 2024
Doc/using/configure.rst
Outdated
| @@ -58,6 +58,9 @@ Features and minimum versions required to build CPython: | |||
| .. versionchanged:: 3.13 | |||
| Autoconf 2.71, aclocal 1.16.4 and SQLite 3.15.2 are now required. | |||
|
|
|||
| .. versionchanged:: 3.13 | |||
| Require aclocal 1.16.5. | |||
There was a problem hiding this comment.
Change the previous 3.13 entry instead.
There was a problem hiding this comment.
Sorry, it was stupid error.
vstinner
reviewed
Oct 14, 2024
Doc/whatsnew/3.13.rst
Outdated
| the :file:`configure` script. | ||
| (Contributed by Christian Heimes in :gh:`89886`.) | ||
| (Contributed by Victor Stinner in :gh:`112090`.) |
There was a problem hiding this comment.
You should keep Christian, I didn't require autoconf 2.71 in d9fd33a.
Something like:
(Contributed by Christian Heimes in :gh:`89886` and by Victor Stinner in :gh:`112090`.)
|
Thanks @efimov-mikhail for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 14, 2024
…GH-125457) (cherry picked from commit 45df264) Co-authored-by: Mikhail Efimov <efimov.mikhail@gmail.com>
|
GH-125459 is a backport of this pull request to the 3.13 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @vstinner
📚 Documentation preview 📚: https://cpython-previews--125457.org.readthedocs.build/