gh-126606: don't write incomplete pyc files #126627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfbolz
requested review from
brettcannon,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
cmaloney
reviewed
Nov 9, 2024
picnixz
added
needs backport to 3.12
Eclips4
reviewed
Nov 9, 2024
Misc/NEWS.d/next/Core_and_Builtins/2024-11-09-16-10-22.gh-issue-126066.9zs4m4.rst
Outdated
Show resolved
Hide resolved
…e-126066.9zs4m4.rst Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
brettcannon
requested changes
Nov 12, 2024
|
When you're done making the requested changes, leave the comment: |
- use swap_attr instead of mock - nicer comments - remove magic constant
|
I have made the requested changes; please review again. |
|
Thanks for making the requested changes! @brettcannon: please review the changes made to this pull request. |
brettcannon
approved these changes
Nov 13, 2024
|
Everything LGTM at this point (I just went ahead and tweaked a comment)! Once CI passes I will merge and hope the backports all succeed. 🤞 |
|
Thanks @cfbolz for the PR, and @brettcannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 13, 2024
(cherry picked from commit c695e37) Co-authored-by: CF Bolz-Tereick <cfbolz@gmx.de> Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru> Co-authored-by: Brett Cannon <brett@python.org>
|
GH-126809 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 13, 2024
(cherry picked from commit c695e37) Co-authored-by: CF Bolz-Tereick <cfbolz@gmx.de> Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru> Co-authored-by: Brett Cannon <brett@python.org>
|
GH-126810 is a backport of this pull request to the 3.12 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix corner case in importlib: so far, the code does not check the return value of
_io.FileIO.writeto see whether a pyc code was fully written to disk. If a ulimit is in place (or the disk is full or something), this could lead to truncated pyc files. After the fix, the written size is checked and the half-written file is removed.