Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-126341: added release check to iteration method of memoryview object #126759

Merged
merged 10 commits into from
Nov 13, 2024
Merged

gh-126341: added release check to iteration method of memoryview object #126759

merged 10 commits into from
Nov 13, 2024

Conversation

ritvikpasham
Copy link
Contributor

@ritvikpasham ritvikpasham commented Nov 12, 2024 •
edited by bedevere-app bot
Loading

@cpython-cla-bot CPython CLA Bot
Copy link

cpython-cla-bot bot commented Nov 12, 2024 •
edited
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Nov 12, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app bedevere-app bot mentioned this pull request Nov 12, 2024
Closed
sobolevn
sobolevn requested changes Nov 12, 2024
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add a test case.

@bedevere-app
Copy link

bedevere-app bot commented Nov 12, 2024

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be put in the comfy chair!

ZeroIntensity
ZeroIntensity reviewed Nov 12, 2024
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing :)

You should be able to use the reproducer from the issue as a test case.

Misc/NEWS.d/next/Core_and_Builtins/2024-11-12-19-24-00.gh-issue-126341.5SdAe1.rst Outdated Show resolved Hide resolved
@ritvikpasham
Copy link
Contributor Author

I have made the requested changes; please review again.

@bedevere-app
Copy link

bedevere-app bot commented Nov 12, 2024

Thanks for making the requested changes!

@sobolevn: please review the changes made to this pull request.

@bedevere-app bedevere-app bot requested a review from sobolevn November 12, 2024 20:18
ZeroIntensity
ZeroIntensity reviewed Nov 12, 2024
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need a whole new file for the test, as it's only a 3 line reproducer. You could just add it alongside the existing tests for memoryview iteration.

Lib/test/memoryview/test_released_iter.py Outdated Show resolved Hide resolved
@ritvikpasham
Copy link
Contributor Author

I don't think we need a whole new file for the test, as it's only a 3 line reproducer. You could just add it alongside the existing tests for memoryview iteration.

Yeah, that makes sense! Would you happen to know where the memoryview iteration tests are?

@ZeroIntensity
Copy link
Member

ZeroIntensity commented Nov 12, 2024 •
edited
Loading

I don't, but you can just CTRL+F iter in the memoryview tests and you'll probably find it :)

@ritvikpasham
Copy link
Contributor Author

It look like there was a previous test case that tests CHECK_RELEASED, so I just added a check to the iter method there.

ZeroIntensity
ZeroIntensity approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@vstinner @sobolevn
Update Misc/NEWS.d/next/Core_and_Builtins/2024-11-12-19-24-00.gh-issu…
a1fe120 
…e-126341.5SdAe1.rst

Co-authored-by: sobolevn <mail@sobolevn.me>
vstinner
vstinner approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for adding a non-regression test!

@vstinner vstinner added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Nov 13, 2024
@vstinner
Copy link
Member

@sobolevn: I let you review the updated PR. You can merge it if it looks good to you.

sobolevn
sobolevn approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sobolevn sobolevn enabled auto-merge (squash) November 13, 2024 11:39
@sobolevn
Copy link
Member

Should we backport this change?

@ZeroIntensity
Copy link
Member

I think so, it's a bugfix.

@sobolevn sobolevn merged commit a12690e into python:main Nov 13, 2024
47 checks passed
@miss-islington-app
Copy link

Thanks @ritvikpasham for the PR, and @sobolevn for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 13, 2024
@ritvikpasham @blurb-it
@ZeroIntensity @vstinner @sobolevn @miss-islington
pythongh-126341: add release check to __iter__ method of `memoryvie…
a741431 
…w` (pythonGH-126759)

(cherry picked from commit a12690e)

Co-authored-by: Ritvik Pasham <ritvikpasham@gmail.com>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: sobolevn <mail@sobolevn.me>
@bedevere-app
Copy link

bedevere-app bot commented Nov 13, 2024

GH-126778 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Nov 13, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 13, 2024
@ritvikpasham @blurb-it
@ZeroIntensity @vstinner @sobolevn @miss-islington
pythongh-126341: add release check to __iter__ method of `memoryvie…
1af10de 
…w` (pythonGH-126759)

(cherry picked from commit a12690e)

Co-authored-by: Ritvik Pasham <ritvikpasham@gmail.com>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: sobolevn <mail@sobolevn.me>
@bedevere-app
Copy link

bedevere-app bot commented Nov 13, 2024

GH-126779 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Nov 13, 2024
@ZeroIntensity
Copy link
Member

Congrats on your first contribution @ritvikpasham 🎉

Eclips4 pushed a commit that referenced this pull request Nov 13, 2024
@miss-islington @ritvikpasham
@blurb-it @ZeroIntensity @vstinner @sobolevn
[3.12] gh-126341: add release check to __iter__ method of `memoryvi…
0bdcc84 
…ew` (GH-126759) (#126779)

gh-126341: add release check to `__iter__` method of `memoryview` (GH-126759)
(cherry picked from commit a12690e)

Co-authored-by: Ritvik Pasham <ritvikpasham@gmail.com>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: sobolevn <mail@sobolevn.me>
Eclips4 pushed a commit that referenced this pull request Nov 13, 2024
@miss-islington @ritvikpasham
@blurb-it @ZeroIntensity @vstinner @sobolevn
[3.13] gh-126341: add release check to __iter__ method of `memoryvi…
3fe062c 
…ew` (GH-126759) (#126778)

gh-126341: add release check to `__iter__` method of `memoryview` (GH-126759)
(cherry picked from commit a12690e)

Co-authored-by: Ritvik Pasham <ritvikpasham@gmail.com>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: sobolevn <mail@sobolevn.me>
picnixz pushed a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
@ritvikpasham @blurb-it
@ZeroIntensity @vstinner @sobolevn @picnixz
pythongh-126341: add release check to __iter__ method of `memoryvie…
0c6ec4a 
…w` (python#126759)

Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: sobolevn <mail@sobolevn.me>
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@ritvikpasham @blurb-it
@ZeroIntensity @vstinner @sobolevn @ebonnal
pythongh-126341: add release check to __iter__ method of `memoryvie…
6adefa1 
…w` (python#126759)

Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: sobolevn <mail@sobolevn.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@sobolevn sobolevn sobolevn approved these changes

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ritvikpasham @ZeroIntensity @vstinner @sobolevn