Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-101100: Fix sphinx warnings of removed opcodes #127222

Merged
merged 1 commit into from
Nov 24, 2024

Conversation

koyuki7w
Copy link
Contributor

@koyuki7w koyuki7w commented Nov 24, 2024

Fixed sphinx warnings:

whatsnew/3.11.rst:1674: WARNING: 'opcode' reference target not found: BEFORE_WITH [ref.opcode]
whatsnew/3.4.rst:1982: WARNING: 'opcode' reference target not found: LOAD_CLASSDEREF [ref.opcode]
whatsnew/3.6.rst:2369: WARNING: 'opcode' reference target not found: FORMAT_VALUE [ref.opcode]
whatsnew/3.6.rst:2374: WARNING: 'opcode' reference target not found: BUILD_CONST_KEY_MAP [ref.opcode]
whatsnew/3.6.rst:2378: WARNING: 'opcode' reference target not found: CALL_FUNCTION [ref.opcode]
whatsnew/3.6.rst:2378: WARNING: 'opcode' reference target not found: CALL_FUNCTION_KW [ref.opcode]
whatsnew/3.6.rst:2378: WARNING: 'opcode' reference target not found: BUILD_MAP_UNPACK_WITH_CALL [ref.opcode]
whatsnew/3.6.rst:2378: WARNING: 'opcode' reference target not found: BUILD_TUPLE_UNPACK_WITH_CALL [ref.opcode]
whatsnew/3.6.rst:2389: WARNING: 'opcode' reference target not found: STORE_ANNOTATION [ref.opcode]
whatsnew/3.7.rst:2479: WARNING: 'opcode' reference target not found: CALL_METHOD [ref.opcode]
whatsnew/3.7.rst:2482: WARNING: 'opcode' reference target not found: STORE_ANNOTATION [ref.opcode]
whatsnew/3.8.rst:2155: WARNING: 'opcode' reference target not found: BREAK_LOOP [ref.opcode]
whatsnew/3.8.rst:2155: WARNING: 'opcode' reference target not found: CONTINUE_LOOP [ref.opcode]
whatsnew/3.8.rst:2155: WARNING: 'opcode' reference target not found: SETUP_LOOP [ref.opcode]
whatsnew/3.8.rst:2155: WARNING: 'opcode' reference target not found: SETUP_EXCEPT [ref.opcode]
whatsnew/3.8.rst:2155: WARNING: 'opcode' reference target not found: ROT_FOUR [ref.opcode]
whatsnew/3.8.rst:2155: WARNING: 'opcode' reference target not found: BEGIN_FINALLY [ref.opcode]
whatsnew/3.8.rst:2155: WARNING: 'opcode' reference target not found: CALL_FINALLY [ref.opcode]
whatsnew/3.8.rst:2155: WARNING: 'opcode' reference target not found: POP_FINALLY [ref.opcode]
whatsnew/3.8.rst:2155: WARNING: 'opcode' reference target not found: END_FINALLY [ref.opcode]
whatsnew/3.8.rst:2155: WARNING: 'opcode' reference target not found: WITH_CLEANUP_START [ref.opcode]
whatsnew/3.9.rst:1206: WARNING: 'opcode' reference target not found: LOAD_ASSERTION_ERROR [ref.opcode]

📚 Documentation preview 📚: https://cpython-previews--127222.org.readthedocs.build/

Fixed sphinx warnings:
```
whatsnew/3.11.rst:1674: WARNING: 'opcode' reference target not found: BEFORE_WITH [ref.opcode]
whatsnew/3.4.rst:1982: WARNING: 'opcode' reference target not found: LOAD_CLASSDEREF [ref.opcode]
whatsnew/3.6.rst:2369: WARNING: 'opcode' reference target not found: FORMAT_VALUE [ref.opcode]
whatsnew/3.6.rst:2374: WARNING: 'opcode' reference target not found: BUILD_CONST_KEY_MAP [ref.opcode]
whatsnew/3.6.rst:2378: WARNING: 'opcode' reference target not found: CALL_FUNCTION [ref.opcode]
whatsnew/3.6.rst:2378: WARNING: 'opcode' reference target not found: CALL_FUNCTION_KW [ref.opcode]
whatsnew/3.6.rst:2378: WARNING: 'opcode' reference target not found: BUILD_MAP_UNPACK_WITH_CALL [ref.opcode]
whatsnew/3.6.rst:2378: WARNING: 'opcode' reference target not found: BUILD_TUPLE_UNPACK_WITH_CALL [ref.opcode]
whatsnew/3.6.rst:2389: WARNING: 'opcode' reference target not found: STORE_ANNOTATION [ref.opcode]
whatsnew/3.7.rst:2479: WARNING: 'opcode' reference target not found: CALL_METHOD [ref.opcode]
whatsnew/3.7.rst:2482: WARNING: 'opcode' reference target not found: STORE_ANNOTATION [ref.opcode]
whatsnew/3.8.rst:2155: WARNING: 'opcode' reference target not found: BREAK_LOOP [ref.opcode]
whatsnew/3.8.rst:2155: WARNING: 'opcode' reference target not found: CONTINUE_LOOP [ref.opcode]
whatsnew/3.8.rst:2155: WARNING: 'opcode' reference target not found: SETUP_LOOP [ref.opcode]
whatsnew/3.8.rst:2155: WARNING: 'opcode' reference target not found: SETUP_EXCEPT [ref.opcode]
whatsnew/3.8.rst:2155: WARNING: 'opcode' reference target not found: ROT_FOUR [ref.opcode]
whatsnew/3.8.rst:2155: WARNING: 'opcode' reference target not found: BEGIN_FINALLY [ref.opcode]
whatsnew/3.8.rst:2155: WARNING: 'opcode' reference target not found: CALL_FINALLY [ref.opcode]
whatsnew/3.8.rst:2155: WARNING: 'opcode' reference target not found: POP_FINALLY [ref.opcode]
whatsnew/3.8.rst:2155: WARNING: 'opcode' reference target not found: END_FINALLY [ref.opcode]
whatsnew/3.8.rst:2155: WARNING: 'opcode' reference target not found: WITH_CLEANUP_START [ref.opcode]
whatsnew/3.9.rst:1206: WARNING: 'opcode' reference target not found: LOAD_ASSERTION_ERROR [ref.opcode]
```
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hugovk hugovk removed needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Nov 24, 2024
@hugovk hugovk merged commit 3d8ac48 into python:main Nov 24, 2024
44 checks passed
@hugovk
Copy link
Member

hugovk commented Nov 24, 2024

Please could you open backports for the 3.13 and 3.12 branches?

We should be careful, because some of these were removed in 3.14, so shouldn't be removed from 3.13 and 3.12 docs.

Likewise, any removed in 3.13 shouldn't be removed from 3.12 docs.

koyuki7w added a commit to koyuki7w/cpython that referenced this pull request Nov 25, 2024
…nGH-127222)

(cherry picked from commit 3d8ac48)

Co-authored-by: Yuki Kobayashi <drsuaimqjgar@gmail.com>
koyuki7w added a commit to koyuki7w/cpython that referenced this pull request Nov 25, 2024
…nGH-127222)

(cherry picked from commit 3d8ac48)

Co-authored-by: Yuki Kobayashi <drsuaimqjgar@gmail.com>
koyuki7w added a commit to koyuki7w/cpython that referenced this pull request Nov 25, 2024
…nGH-127222)

(cherry picked from commit 3d8ac48)

Co-authored-by: Yuki Kobayashi <drsuaimqjgar@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Nov 25, 2024

GH-127239 is a backport of this pull request to the 3.13 branch.

@bedevere-app
Copy link

bedevere-app bot commented Nov 25, 2024

GH-127240 is a backport of this pull request to the 3.12 branch.

@koyuki7w
Copy link
Contributor Author

@hugovk Thanks for reviewing. Opened PRs for 3.13 and 3.12 backports.

@hugovk
Copy link
Member

hugovk commented Nov 25, 2024

Thank you!

ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants