-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-127347: Document traceback.print_list
#127348
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need blurb entries for documentation changes :)
Thank you! Documentation entry looks good for me. Let's also add a |
Yeah I wasn't sure whether I should add it or not, but it was easy to write so I went with it 😄 I can remove it though |
Yeah, let's remove it. |
I don't think we should remove it. If we expose |
Oh, I was under the impression that was going to be done in a separate PR for backporting (adding to |
Done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Misc/NEWS.d/next/Documentation/2024-11-27-22-56-48.gh-issue-127347.xyddWS.rst
Outdated
Show resolved
Hide resolved
Based in Serhiy's comment I believe this should be good to go. How should we handle the backports? Should I create them manually since they should only contain the documentation changes (w/o modifying |
Triagers can edit izzy's PRs, right? I think you can just let the bot do the automatic backport and then remove it from |
Yeah if I can edit the PR, that would make it easier 👍 |
Previously, `traceback.print_list` didn't have a documentation entry and was not exposed in `traceback.__all__`. Now it has a documentation entry and is exposed in `__all__`. (cherry picked from commit 8ba9f5b) Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
Thank you, Tomas! |
Previously, `traceback.print_list` didn't have a documentation entry and was not exposed in `traceback.__all__`. Now it has a documentation entry and is exposed in `__all__`. (cherry picked from commit 8ba9f5b) Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
GH-127569 is a backport of this pull request to the 3.13 branch. |
GH-127570 is a backport of this pull request to the 3.12 branch. |
Yup, triagers can push to other forks of python/cpython repo. |
Great! I'll edit the backports later today :) |
|
The buildbot failure does not seem related to this PR |
Add an documentation entry about `traceback.print_list` Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
Add an documentation entry about `traceback.print_list` Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
Previously, `traceback.print_list` didn't have a documentation entry and was not exposed in `traceback.__all__`. Now it has a documentation entry and is exposed in `__all__`.
Previously, `traceback.print_list` didn't have a documentation entry and was not exposed in `traceback.__all__`. Now it has a documentation entry and is exposed in `__all__`.
traceback.print_list
#127347📚 Documentation preview 📚: https://cpython-previews--127348.org.readthedocs.build/