gh-127257: Add hex code to ssl "unknown error" message #127360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make it easier to vary the individual parts of the message, replace the if-ladder with constant format strings by building the string piece-wise with PyUnicodeWriter. Use "unknown error (0x%x)" rather than just "unknown error" if we can't get a better error message. (Hex makes sense as the error includes two packed parts.)
encukou
changed the title
|
!buildbot Arch.Linux |
|
🤖 New build scheduled with the buildbot fleet by @encukou for commit 87f1452 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not fix #127257 but would have made it easier to debug.
To make it easier to vary the individual parts of the message,
replace the if-ladder with a few constant format strings by
building the string piece-wise using PyUnicodeWriter.
Use "unknown error (0x%x)" rather than just "unknown error"
if we can't get a better error message. (Hex makes sense as
the error includes two byte-packed parts.)
As there are no cases where we should raise an "unknown error",
I don't see a good way to add tests. But, we can verify using the
current failure on Arch Linux buildbots.
Existing tests do cover error messages.