GH-125413: Add pathlib.Path.info attribute
#127730
Conversation
When a path object is generated by `PathBase.iterdir()`, then its `_info` attribute now stores a `os.DirEntry`-like object that can be used to query the file type. This removes any need for a `_scandir()` method. Currently the `_info` attribute is private and only guaranteed to be populated in paths from `iterdir()`. Later on, I'm hoping to rename it to `info` and ensure that it's populated for all kinds of paths (this probably involves adding a `pathlib.FileInfo` class.) In the pathlib ABCs, `info` will replace `stat()` as the lowest-level abstract file status querying mechanism.
|
Steve - hopefully this helps address the issues you raised in #127377, but perhaps I'm only moving the problem around here. |
|
I think this is just moving stuff around. It might end up being the right places, but let's see the Discourse discussion play out a bit first. |
barneygale
changed the title
_scandir() with _info_scandir() with _status
barneygale
changed the title
_scandir() with _statuspathlib.Path.status attribute
|
I've revised the PR to be a more complete implementation of what I described on the forum, mostly as a demonstration/proof-of-concept at this stage. |
|
Hi Petr, I've requested your review on this PR, but at this stage what I most need is a sense-check: does it take the right approach and avoid the pitfalls you outlined in this forum thread? Thank you. |
|
Sorry for getting to this late; I think we moved on in the Discourse thread instead :) |
|
This is up-to-date with my latest proposal on Discourse in fact! Actually you mentioned making this a method rather than a property, which I haven't done here. I'll bring it up on the forum. |
|
Right, I think this is ready for review. Alyssa, sorry if this seems like deja-vu! |
barneygale
changed the title
pathlib.Path.status attributepathlib.Path.info attribute
Add
pathlib.Path.infoattribute, which stores an object implementing thepathlib.types.PathInfoprotocol (also new). The object supports querying the file type and internally cachingos.stat()results. Path objects generated byPath.iterdir()are initialised with status information fromos.DirEntryobjects, which is gleaned from scanning the parent directory.The
PathInfoprotocol has four methods:exists(),is_dir(),is_file()andis_symlink().os.DirEntryobjects from pathlib #125413