bpo-29643: Fix check for --enable-optimizations #129
Conversation
The presence of the --enable-optimizations flag is indicated by the value of $enableval, but the configure script was checking $withval, resulting in the --enable-optimizations flag being effectively ignored.
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA. This is necessary for legal reasons before we can look at your contribution. Please follow these steps to help rectify the issue:
Thanks again to your contribution and we look forward to looking at it! |
|
I have signed the CLA.
… On Feb 16, 2017, at 12:57 AM, the-knights-who-say-ni ***@***.***> wrote:
Hello, and thanks for your contribution!
I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement <https://www.python.org/psf/contrib/contrib-form/> (CLA).
Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org <http://bugs.python.org/> (b.p.o) to verify you have signed the CLA. This is necessary for legal reasons before we can look at your contribution. Please follow these steps to help rectify the issue:
If you don't have an account on b.p.o, please create one ***@***.***=register>
Make sure your GitHub username is listed in "Your Details" at b.p.o <https://cloud.githubusercontent.com/assets/2680980/22867185/d3aedcf8-f137-11e6-8469-d5f7861a1073.png>
If you have not already done so, please sign the PSF contributor agreement <https://www.python.org/psf/contrib/contrib-form/>
If you just signed the CLA, please wait at least one US business day and then check "Your Details" on bugs.python.org <https://bugs.python.org/> to see if your account has been marked as having signed the CLA (the delay is due to a person having to manually check your signed CLA)
Reply here saying you have completed the above steps
Thanks again to your contribution and we look forward to looking at it!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#129 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAilLLVQvNG2dm0Gp9C0pmXkbZW2LudLks5rc-VFgaJpZM4MCnaf>.
|
|
It would be nice to open an issue on http://bugs.python.org/ to track this problem. And don't forget to nosy @brettcannon . |
|
My Makefile knowledge is fairly limited so I'm adding @gpshead to see if he is up for reviewing. If not then I can handle it. And can you open an issue on bugs.python.org for this, @aw1621107 ? |
|
Oops, forgot about that. Submitted issue 29643. Sorry about the delay. |
brettcannon
changed the title
|
thanks, this change looks good. |
|
When checking it in, we need to check in regenerated configure files along with it. but that could make easy backporting/merging a pain. do we have a process preference for configure.ac & configure changes? or just leave it up to whomever is merging? |
|
@gpshead I think we have a version requirement specified in configure.ac, but otherwise the committer just runs autoconf and commits both configure.ac and configure. |
|
I'm sorry. I failed to merge master and I used |
|
When I ran autoreconf, unrelated changes (pkg-config 0.29 -> 0.29.2) happens. |
|
@methane: The change to aclocal.m4 should not matter one way or another. You can leave it in or not. |
The presence of the ``--enable-optimizations`` flag is indicated by the value of ``$enableval``, but the configure script was checking ``$withval``, resulting in the ``--enable-optimizations`` flag being effectively ignored. (cherry picked from commit 8cea592)
The presence of the ``--enable-optimizations`` flag is indicated by the value of ``$enableval``, but the configure script was checking ``$withval``, resulting in the ``--enable-optimizations`` flag being effectively ignored. (cherry picked from commit 8cea592)
The presence of the ``--enable-optimizations`` flag is indicated by the value of ``$enableval``, but the configure script was checking ``$withval``, resulting in the ``--enable-optimizations`` flag being effectively ignored. (cherry picked from commit 8cea592)
Re-add the test for NULL. It got lost in change 20dad21ded9c (2.7-slp) and dae0e80f141d (3.2-slp). Update the documentation. https://bitbucket.org/stackless-dev/stackless/issues/129 (grafted from a4dfdadc7cf547e7f589e8191b8bab2c67e34f00)
missing ref on the return value Fixes python#129
missing ref on the return value Fixes python#129
The presence of the --enable-optimizations flag is indicated by the
value of $enableval, but the configure script was checking $withval,
resulting in the --enable-optimizations flag being effectively ignored.