Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-111178: fix UBSan failures in Modules/_ctypes #129071

Merged
merged 13 commits into from
Jan 21, 2025
Merged

gh-111178: fix UBSan failures in Modules/_ctypes #129071

merged 13 commits into from
Jan 21, 2025

Conversation

picnixz
Copy link
Member

@picnixz picnixz commented Jan 20, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Jan 20, 2025
Open
ZeroIntensity
ZeroIntensity reviewed Jan 20, 2025
View reviewed changes
Modules/_ctypes/_ctypes.c Outdated Show resolved Hide resolved
Modules/_ctypes/_ctypes.c Show resolved Hide resolved
Modules/_ctypes/_ctypes.c Show resolved Hide resolved
encukou
encukou reviewed Jan 20, 2025
View reviewed changes
Copy link
Member

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Modules/_ctypes/_ctypes.c Outdated Show resolved Hide resolved
encukou
encukou approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Don't worry about making it any prettier.

@picnixz
Copy link
Member Author

picnixz commented Jan 20, 2025

@vstinner I plan to merge this one with no commit message and the PR's title as the commit's title.

vstinner
vstinner approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes LGTM. I didn't test the change.

@picnixz picnixz merged commit fafc618 into python:main Jan 21, 2025
44 checks passed
@picnixz picnixz deleted the fix/ubsan/ctypes-111178 branch January 21, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeroIntensity ZeroIntensity ZeroIntensity left review comments

@encukou encukou encukou approved these changes

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@picnixz @vstinner @encukou @ZeroIntensity