doc: fix venv creating for the local Python using uv #129094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pythonGH-120711 introduced uv as an alternative venv provisioning and method, but failed to honor the `PYTHON` variable, leading uv to the system's default Python installation. Honoring `PYTHON` is important for use cases such as `doctest`, which should run with the locally built Python. Signed-off-by: Filipe Laíns <lains@riseup.net>
hugovk
added
needs backport to 3.12
|
Thanks, we should make the same change to the Makefile in the devguide, docs-community and peps repos. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 20, 2025
(cherry picked from commit da36bcc) Co-authored-by: Filipe Laíns 🇵🇸 <lains@riseup.net>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 20, 2025
(cherry picked from commit da36bcc) Co-authored-by: Filipe Laíns 🇵🇸 <lains@riseup.net>
|
GH-129096 is a backport of this pull request to the 3.13 branch. |
|
GH-129097 is a backport of this pull request to the 3.12 branch. |
hugovk
pushed a commit
that referenced
this pull request
Jan 20, 2025
… (#129096) Co-authored-by: Filipe Laíns 🇵🇸 <lains@riseup.net>
hugovk
pushed a commit
that referenced
this pull request
Jan 20, 2025
… (#129097) Co-authored-by: Filipe Laíns 🇵🇸 <lains@riseup.net>
This was referenced Jan 20, 2025
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GH-120711 introduced uv as an alternative venv provisioning and method, but failed to honor the
PYTHONvariable, leading uv to the system's default Python installation. HonoringPYTHONis important for use cases such asdoctest, which should run with the locally built Python.📚 Documentation preview 📚: https://cpython-previews--129094.org.readthedocs.build/