gh-129354: Fix grammar in PyErr_FormatUnraisable() #129475
Merged
+79
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstinner
requested review from
ericsnowcurrently,
kumaraditya303,
FFY00,
markshannon and
iritkatriel
as code owners
|
As long as we're bikeshedding this, now I'm feeling like "while" is the most appropriate word. We are ignoring an error that occurred while whatever other action was in progress. "When" feels more appropriate for something that occurred at an instant, versus "while" for a duration. But it's pretty nitpicky... |
Replace "on verb+ing" with "while verb+ing".
vstinner
force-pushed
the
format_unraisable_when
branch
from
9c2fcd9 to
6f0e248
Compare
vstinner
requested review from
pganssle,
abalkin,
methane,
brandtbucher and
savannahostrowski
as code owners
Oh, ok. I updated my PR to use "while". Would you mind to review the updated PR? |
|
Merged, thanks for the review @hoodmane. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace "on verb+ing" with "when verb+ing".
PyErr_WriteUnraisable()withPyErr_FormatUnraisable()#129354