GH-128563: Simplify recursion check in _PyEval_EvalFrameDefault
#129481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
markshannon
commented
Jan 30, 2025
•
markshannon
commented
- Issue: A new tail-calling interpreter for significantly better interpreter performance #128563
Fidget-Spinner
requested changes
Jan 31, 2025
| @@ -786,7 +786,11 @@ _PyEval_EvalFrameDefault(PyThreadState *tstate, _PyInterpreterFrame *frame, int | |||
|
|
|||
| _PyInterpreterFrame entry_frame; | |||
|
|
|||
|
|
|||
| if (_Py_EnterRecursiveCallTstate(tstate, "")) { | |||
| assert(frame->owner != FRAME_OWNED_BY_INTERPRETER); | |||
There was a problem hiding this comment.
Don't you need to _Py_LeaveRecursiveCallPy after this as well?
At least from reading the code of exit_unwind.
There was a problem hiding this comment.
No. We haven't called _Py_EnterRecursivePy
|
When you're done making the requested changes, leave the comment: |
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @Fidget-Spinner: please review the changes made to this pull request. |
Fidget-Spinner
approved these changes
Jan 31, 2025
mpage
added a commit
to mpage/cpython
that referenced
this pull request
Feb 1, 2025
…meDefault` (pythonGH-129481)" This reverts commit c3ae5c9.
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Feb 7, 2025
…t` (pythonGH-129481) Simplify recursion check in _PyEval_EvalFrameDefault
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.