-
-
Notifications
You must be signed in to change notification settings - Fork 31.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-36797: Prune more legacy distutils documentation #13092
bpo-36797: Prune more legacy distutils documentation #13092
Conversation
@pganssle Reviewing @kojoidrissa's change in #13087 prompted me to make the markings on the rest of the legacy distutils docs a bit more emphatic in saying "This probably isn't the page you want to be looking at" |
Hm, would it be worth it to move the Given that there's a URL in it, it might be worth it to have a canonical stub for this. |
@pganssle Yeah, that would make a lot of sense. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ated-distutils-information
@@ -4,6 +4,16 @@ | |||
API Reference | |||
************* | |||
|
|||
.. seealso:: | |||
|
|||
`New and changed setup.py arguments in setuptools <setuptools-setup-py>`_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ncoghlan This is a dead link to https://docs.python.org/3.8/distutils/setuptools-setup-py
See linkchecker output:
URL `setuptools-setup-py'
Name `New and changed setup.py arguments in setuptools'
Parent URL file:///builddir/build/BUILD/Python-3.8.0b4/Doc/build/html/distutils/apiref.html, line 106, col 5
Real URL file:///builddir/build/BUILD/Python-3.8.0b4/Doc/build/html/distutils/setuptools-setup-py
Check time 0.001 seconds
Result Error: URLError: <urlopen error [Errno 2] No such file or directory: '/builddir/build/BUILD/Python-3.8.0b4/Doc/build/html/distutils/setuptools-setup-py'>
4 threads active, 0 links queued, 4445 links in 4449 URLs checked, runtime 1 minute, 46 seconds
Where is this actually supposed to lead to?
and other APIs, makes the API consistent across different Python versions, | ||
and is hence recommended over using ``distutils`` directly. | ||
|
||
.. _setuptools-setup-py: https://setuptools.readthedocs.io/en/latest/setuptools.html#new-and-changed-setup-keywords |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I see, this should be the link. I'll prep a PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://bugs.python.org/issue36797