-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-28269: Replace strcasecmp with system function stricmp #13095
Conversation
Microsoft deprecated |
Just tried, MinGW also accept _stricmp. I'll use it instead. Thanks @serhiy-storchaka . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @gongminmin :)
@skrah, do you think it is worth deleting those lines too?
cpython/Modules/_decimal/libmpdec/vccompat.h
Lines 46 to 47 in 3880f26
#undef strcasecmp | |
#define strcasecmp _stricmp |
And also update this comment to remove any occurrences of strcasecmp
?
cpython/Modules/_decimal/libmpdec/io.c
Line 55 in 74d7f76
* Work around the behavior of tolower() and strcasecmp() in certain |
Misc/NEWS.d/next/Windows/2019-05-05-05-23-34.bpo-28269.-MOHI7.rst
Outdated
Show resolved
Hide resolved
Co-Authored-By: Mickaël Schoentgen <contact@tiger-222.fr>
No, |
Ping? |
Thanks @gongminmin for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.7, 3.8. |
GH-14740 is a backport of this pull request to the 3.8 branch. |
GH-14741 is a backport of this pull request to the 3.7 branch. |
Sorry, @gongminmin and @serhiy-storchaka, I could not cleanly backport this to |
This commit integrates changes originally added to the project as python-cmake-buildsystem/python-cmake-buildsystem@18d49757e (Mingw32 support, and add cmake options for disabling) Note that in more recent version of Python, this patch is obsoleted by the following commits: See python/cpython@589f89e2a (introduced in 3.3) Removed a Windows 9x trick used before LoadLibraryExW. Windows 9x has long been unsupported and the result of GetFullPathName was not even being used in the first place. See python/cpython@05f2d84ca (introduced in 3.9) bpo-28269: Replace strcasecmp with system function _stricmp. (pythonGH-13095) Co-authored-by: David Sansome <me@davidsansome.com>
This commit integrates changes originally added to the project as python-cmake-buildsystem/python-cmake-buildsystem@18d49757e (Mingw32 support, and add cmake options for disabling) Note that in more recent version of Python, this patch is obsoleted by the following commits: See python/cpython@589f89e2a (introduced in 3.3) Removed a Windows 9x trick used before LoadLibraryExW. Windows 9x has long been unsupported and the result of GetFullPathName was not even being used in the first place. See python/cpython@05f2d84ca (introduced in 3.9) bpo-28269: Replace strcasecmp with system function _stricmp. (pythonGH-13095) Co-authored-by: David Sansome <me@davidsansome.com>
This commit integrates changes originally added to the project as python-cmake-buildsystem/python-cmake-buildsystem@18d49757e (Mingw32 support, and add cmake options for disabling) Note that in more recent version of Python, this patch is obsoleted by the following commits: See python/cpython@589f89e2a (introduced in 3.3) Removed a Windows 9x trick used before LoadLibraryExW. Windows 9x has long been unsupported and the result of GetFullPathName was not even being used in the first place. See python/cpython@05f2d84ca (introduced in 3.9) bpo-28269: Replace strcasecmp with system function _stricmp. (pythonGH-13095) Co-authored-by: David Sansome <me@davidsansome.com>
This commit integrates changes originally added to the project as python-cmake-buildsystem/python-cmake-buildsystem@18d49757e (Mingw32 support, and add cmake options for disabling) Note that in more recent version of Python, this patch is obsoleted by the following commits: See python/cpython@589f89e2a (introduced in 3.3) Removed a Windows 9x trick used before LoadLibraryExW. Windows 9x has long been unsupported and the result of GetFullPathName was not even being used in the first place. See python/cpython@05f2d84ca (introduced in 3.9) bpo-28269: Replace strcasecmp with system function _stricmp. (pythonGH-13095) Co-authored-by: David Sansome <me@davidsansome.com>
The idea is from a comment in the issue. Replace strcasecmp in Python/dynload_win.c to posix stricmp,
https://bugs.python.org/issue28269