Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-36817: Fix reference leak for expr_text in f-string = parsing #13249

Merged
merged 1 commit into from
May 11, 2019
Merged

bpo-36817: Fix reference leak for expr_text in f-string = parsing #13249

merged 1 commit into from
May 11, 2019

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented May 11, 2019 •
edited by bedevere-bot
Loading

@pablogsal pablogsal requested review from larryhastings, ilevkivskyi and ericvsmith and removed request for ilevkivskyi May 11, 2019 17:18
@pablogsal pablogsal self-assigned this May 11, 2019
@pablogsal
Copy link
Member Author

❯ ./python -m test test_future -m test_annotations -R :
Run tests sequentially
0:00:00 load avg: 0.66 [1/1] test_future
beginning 9 repetitions
123456789
.........
test_future passed

== Tests result: SUCCESS ==

1 test OK.

Total duration: 324 ms
Tests result: SUCCESS

ilevkivskyi
ilevkivskyi approved these changes May 11, 2019
View reviewed changes
Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! LGTM.

ericvsmith
ericvsmith approved these changes May 11, 2019
View reviewed changes
Copy link
Member

@ericvsmith ericvsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this. I kept thinking "I need to remember to make sure that memory gets freed", and then I forgot to do it.

@pablogsal
Copy link
Member Author

I am restarting the CI because appveyor failed with some random asyncio error.

@pablogsal pablogsal merged commit 5833e94 into python:master May 11, 2019
@pablogsal pablogsal deleted the refleak_fstring branch May 11, 2019 19:54
@ericvsmith ericvsmith mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

@ericvsmith ericvsmith ericvsmith approved these changes

@larryhastings larryhastings Awaiting requested review from larryhastings

Assignees

@pablogsal pablogsal

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pablogsal @ericvsmith @ilevkivskyi @the-knights-who-say-ni @bedevere-bot