Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-37035: Don't log OSError #13548

Merged
merged 4 commits into from
May 27, 2019
Merged

bpo-37035: Don't log OSError #13548

merged 4 commits into from
May 27, 2019

Conversation

asvetlov
Copy link
Contributor

@asvetlov asvetlov commented May 24, 2019 •
edited by bedevere-bot
Loading

@asvetlov asvetlov requested a review from 1st1 as a code owner May 24, 2019 15:11
@asvetlov
Copy link
Contributor Author

ready for review

@asvetlov @Carreau
Update Misc/NEWS.d/next/Library/2019-05-24-18-16-07.bpo-37035.HFbJVT.rst
b47306a 
Co-Authored-By: Matthias Bussonnier <bussonniermatthias@gmail.com>
@asvetlov asvetlov mentioned this pull request May 27, 2019
Closed
1st1
1st1 approved these changes May 27, 2019
View reviewed changes
Copy link
Member

@1st1 1st1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider fixing the NEWS entry as I suggested

@asvetlov
Copy link
Contributor Author

I've updated NEWS.
Is it ok now?

@1st1
Copy link
Member

1st1 commented May 27, 2019

Is it ok now?

Yeah, thanks. This will make the what's new editor life easier.

@miss-islington miss-islington merged commit 1f39c28 into python:master May 27, 2019
@miss-islington
Copy link
Contributor

Thanks @asvetlov for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @asvetlov, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 1f39c28e489cca0397fc4c3675d13569318122ac 3.7

@miss-islington miss-islington self-assigned this May 27, 2019
@1st1
Copy link
Member

1st1 commented May 27, 2019

@asvetlov You sure it's a good idea to backport this to 3.7? I wouldn't do that in a point release.

@asvetlov
Copy link
Contributor Author

It is just logging.
No behavior changing.
If you strongly disagree I'll skip the backporting.
My motivation is that: now Python 3.7 users have their logs spammed with annoying messages. Applying this PR to 3.7 can help them a lot.
Now the only recommendation is loop.set_exception_handler(lambda loop, ctx: None) which is terrible.

@1st1
Copy link
Member

1st1 commented May 27, 2019

Applying this PR to 3.7 can help them a lot.

OK; if you think so.

@asvetlov asvetlov mentioned this pull request May 27, 2019
Closed
@bedevere-bot
Copy link

GH-13594 is a backport of this pull request to the 3.7 branch.

asvetlov added a commit to asvetlov/cpython that referenced this pull request May 27, 2019
@asvetlov
[3.7] bpo-37035: Don't log OSError (pythonGH-13548)
ec53d1b 
https://bugs.python.org/issue37035.
(cherry picked from commit 1f39c28)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
@asvetlov asvetlov deleted the asyncio-skip-oserror-logging branch May 27, 2019 14:28
asvetlov added a commit that referenced this pull request May 27, 2019
@asvetlov
[3.7] bpo-37035: Don't log OSError (GH-13548) (#13594)
a79b6c5 
https://bugs.python.org/issue37035.
(cherry picked from commit 1f39c28)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
@asvetlov asvetlov mentioned this pull request May 27, 2019
Closed
@mjpieters mjpieters mentioned this pull request Jun 26, 2019
Closed
This was referenced Jul 13, 2019
Closed
Merged
@Harmon758 Harmon758 mentioned this pull request Jul 19, 2019
Closed
@Harmon758 Harmon758 mentioned this pull request Oct 28, 2019
Closed
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@asvetlov @DinoV
bpo-37035: Don't log OSError (pythonGH-13548)
548cdb0 
https://bugs.python.org/issue37035
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auvipy auvipy auvipy approved these changes

@Carreau Carreau Carreau approved these changes

@1st1 1st1 1st1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@asvetlov @1st1 @miss-islington @bedevere-bot @Carreau @auvipy @the-knights-who-say-ni