Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-37085: Expose SocketCAN bcm_msg_head flags #13646

Merged

Commits on Jun 18, 2019

  1. bpo-37085: Expose SocketCAN bcm_msg_head flags

    Expose the CAN_BCM SocketCAN constants used in the bcm_msg_head struct
    flags (provided by <linux/can/bcm.h>) under the socket library.
    
    This adds the following constants with a CAN_BCM prefix:
    
      * SETTIMER
      * STARTTIMER
      * TX_COUNTEVT
      * TX_ANNOUNCE
      * TX_CP_CAN_ID
      * RX_FILTER_ID
      * RX_CHECK_DLC
      * RX_NO_AUTOTIMER
      * RX_ANNOUNCE_RESUME
      * TX_RESET_MULTI_IDX
      * RX_RTR_FRAME
      * CAN_FD_FRAME
    karlding committed Jun 18, 2019
    Configuration menu
    Copy the full SHA
    6d1d880 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2019

  1. bpo-37085: Only use #ifdef for CAN_FD_FRAME

    The CAN_FD_FRAME flag was introduced in the 4.8 kernel, while the other
    ones were present since SocketCAN drivers were mainlined in 2.6.25. As
    such, it is probably unnecessary to guard against these constants being
    missing.
    karlding committed Jul 23, 2019
    Configuration menu
    Copy the full SHA
    604bea9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9e0b9c7 View commit details
    Browse the repository at this point in the history
  3. Add note in docs about CAN_BCM_CAN_FD_FRAME

    The CAN_BCM_CAN_FD_FRAME constant mirrors the availability in the Linux
    kernel. This constant was introduced in Linux 4.8 kernels.
    karlding committed Jul 23, 2019
    Configuration menu
    Copy the full SHA
    28662f1 View commit details
    Browse the repository at this point in the history
  4. bpo-37085: Use support.requires_linux_version

    Use support.requires_linux_version to guard BCM flag CAN_FD_FRAME,
    which is only present on Linux >= 4.8.
    karlding committed Jul 23, 2019
    Configuration menu
    Copy the full SHA
    b969e22 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2019

  1. bpo-37085: Update NEWS entry

    karlding committed Jul 25, 2019
    Configuration menu
    Copy the full SHA
    128c1c1 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2019

  1. bpo-37085: Remove test for CAN_BCM_CAN_FD_FRAME

    This constant doesn't exist on Ubuntu 16.04 LTS, since linux-libc-dev
    ships 4.4.x headers from the repos, while the feature was added in the
    4.8.x kernel series. However, Ubuntu 16.04 supports the 4.15.x kernel
    series, but since linux-libc-dev isn't updated past 4.4.x headers, there
    is no guarantee that /usr/include/linux/can/bcm.h contains the proper
    constant for the userspace API, despite having a supported kernel.
    karlding committed Jul 29, 2019
    Configuration menu
    Copy the full SHA
    56dca1b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0800558 View commit details
    Browse the repository at this point in the history
  3. reword NEWS entry

    taleinat committed Jul 29, 2019
    Configuration menu
    Copy the full SHA
    f1d212d View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2019

  1. Fix sphinx note directive warning in socket docs

    Fix the sphinx warning message that is causing the CI failure:
    
        Content block expected for the "note" directive; none found.
    
    This is done by increasing the indentation to place the text in a block.
    karlding committed Jul 30, 2019
    Configuration menu
    Copy the full SHA
    b28857f View commit details
    Browse the repository at this point in the history