-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve signal documentation #14274
Improve signal documentation #14274
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi and thank you for the pull request.
I've left a suggestion about the changes.
Thanks a lot :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. I think the change is generally fine. I just prefer if the sentences are without parenthesis.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
I have made the requested changes; please review again. |
Thanks for making the requested changes! @Mariatta: please review the changes made to this pull request. |
LGTM. |
Sorry for the delay in reviewing. I got a lot going on. Looks good to me. Thanks! |
Sorry, I can't merge this PR. Reason: |
Sorry, I can't merge this PR. Reason: |
Thanks @maggyero for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
* add a missing ``.. availability::`` reST explicit markup; * more consistent "see man page" sentences. (cherry picked from commit cfebfef) Co-authored-by: Géry Ogam <gery.ogam@gmail.com>
GH-15151 is a backport of this pull request to the 3.8 branch. |
* add a missing ``.. availability::`` reST explicit markup; * more consistent "see man page" sentences. (cherry picked from commit cfebfef) Co-authored-by: Géry Ogam <gery.ogam@gmail.com>
GH-15152 is a backport of this pull request to the 3.7 branch. |
* add a missing ``.. availability::`` reST explicit markup; * more consistent "see man page" sentences. (cherry picked from commit cfebfef) Co-authored-by: Géry Ogam <gery.ogam@gmail.com>
* add a missing ``.. availability::`` reST explicit markup; * more consistent "see man page" sentences. (cherry picked from commit cfebfef) Co-authored-by: Géry Ogam <gery.ogam@gmail.com>
Thanks for reviewing this @Mariatta. |
* add a missing ``.. availability::`` reST explicit markup; * more consistent "see man page" sentences.
* add a missing ``.. availability::`` reST explicit markup; * more consistent "see man page" sentences.
* add a missing ``.. availability::`` reST explicit markup; * more consistent "see man page" sentences.
.. availability::
reST explicit markup;Automerge-Triggered-By: @Mariatta