-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-18049: Sync thread stack size to main thread size on macOS #14748
Conversation
This changeset increases the size of the stack for threads on macOS to the size of the stack of the main thread and reenables the relevant recursion test.
Is this something that can be back ported to 3.8 as it is still in beta? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@@ -0,0 +1,2 @@ | |||
Increase stack size of threads to 16MB on macOS, to match the stack size of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind to mention the old value, 5 MiB?
You may specify that it's the default size: it can be overriden by _thread.stack_size(size).
For me it's a bugfix and so can be backported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Sure, I think backporting to 3.8 is fine. I will run more tests on older versions of macOS before the next beta.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I just have a minor comment.
@@ -0,0 +1,3 @@ | |||
Increase the default stack size of threads from 5MB to 16MB on macOS, to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick:
Increase the default stack size of threads from 5MB to 16MB on macOS, to | |
Increase the default stack size of threads from 5 MiB to 16 MiB on macOS, to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is MiB something we use elsewhere?
I'm probably old, but don't particularly like the MiB vs. MB distinction as it is often clear from the context what's meant.
Well, it's not a big deal, just a remark. I already approved your PR twice ;-) It's up to you. For MiB, see my PR #4293: "kB (kilo byte) unit means 1000 bytes, whereas KiB ("kibibyte") And my commit 8c663fd:
5 MB means 5 000 000 bytes, not Sadly MB (megabyte) is used instead of MiB in many places (outside Python).
|
Thanks @ronaldoussoren for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
…nGH-14748) This changeset increases the default size of the stack for threads on macOS to the size of the stack of the main thread and reenables the relevant recursion test. (cherry picked from commit 1a057ba) Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
GH-15065 is a backport of this pull request to the 3.8 branch. |
) This changeset increases the default size of the stack for threads on macOS to the size of the stack of the main thread and reenables the relevant recursion test. (cherry picked from commit 1a057ba) Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
…nGH-14748) This changeset increases the default size of the stack for threads on macOS to the size of the stack of the main thread and reenables the relevant recursion test.
…nGH-14748) This changeset increases the default size of the stack for threads on macOS to the size of the stack of the main thread and reenables the relevant recursion test.
…nGH-14748) This changeset increases the default size of the stack for threads on macOS to the size of the stack of the main thread and reenables the relevant recursion test.
This changeset increases the size of the stack
for threads on macOS to the size of the stack
of the main thread and reenables the relevant
recursion test.
https://bugs.python.org/issue18049