Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-36084: Add threading Native ID information to What's New documentation #14845

Merged
merged 5 commits into from
Jul 30, 2019

Conversation

jaketesler
Copy link
Contributor

@jaketesler jaketesler commented Jul 18, 2019

This PR includes a minor documentation change. It adds a short blurb to the "What's New in Python 3.8" doc about the new Threading module Native ID functionality (threading.get_native_id(), et al.)

If this PR for :master is approved, I will create a backport PR for the :3.8 branch.

See #13463 (bpo-36084) for more information.

cc @vstinner, @pitrou

https://bugs.python.org/issue36084

Doc/whatsnew/3.8.rst Outdated Show resolved Hide resolved
@jaketesler jaketesler changed the title Add threading Native ID information to What's New documentation bpo-36084: Add threading Native ID information to What's New documentation Jul 24, 2019
@jaketesler
Copy link
Contributor Author

I didn't expect the Spanish Inquisition

@bedevere-bot
Copy link

Nobody expects the Spanish Inquisition!

: please review the changes made to this pull request.

@jaketesler
Copy link
Contributor Author

^ I did that since @bedevere-bot didn't initially add any labels and I didn't want this small PR to get lost in the fray.

Update 3.8 doc wording to match `Threading` reference documentation
@jaketesler
Copy link
Contributor Author

@vstinner Updated the 3.8 doc per your suggestion.

@miss-islington
Copy link
Contributor

Thanks @jaketesler for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-15028 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 30, 2019
…ation (pythonGH-14845)

(cherry picked from commit 84846b0)

Co-authored-by: Jake Tesler <jake.tesler@gmail.com>
miss-islington added a commit that referenced this pull request Jul 30, 2019
…ation (GH-14845)

(cherry picked from commit 84846b0)

Co-authored-by: Jake Tesler <jake.tesler@gmail.com>
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants