Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-34160: explain how to deal with attribute order in ElementTree #14867

Merged
merged 4 commits into from
Jul 24, 2019

Conversation

scoder
Copy link
Contributor

@scoder scoder commented Jul 19, 2019

@scoder scoder added docs Documentation in the Doc dir skip news labels Jul 19, 2019
@scoder scoder changed the title bpo-34160: explain how to deal with attribute order bpo-34160: explain how to deal with attribute order in ElementTree Jul 21, 2019
Copy link
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scoder scoder merged commit a3697db into python:master Jul 24, 2019
@miss-islington
Copy link
Contributor

Thanks @scoder for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @scoder, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker a3697db0102b9b6747fe36009e42f9b08f0c1ea8 3.8

@miss-islington
Copy link
Contributor

Thanks @scoder for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 24, 2019
…ythonGH-14867)

* Fix the formatting in the documentation of the tostring() functions.

* bpo-34160: Document that the tostring() and tostringlist() functions also preserve the attribute order now.

* bpo-34160: Add an explanation of how users should deal with the attribute order.
(cherry picked from commit a3697db)

Co-authored-by: Stefan Behnel <stefan_ml@behnel.de>
@bedevere-bot
Copy link

GH-14935 is a backport of this pull request to the 3.8 branch.

@scoder scoder deleted the bpo-34160_document_change branch July 24, 2019 18:29
scoder added a commit that referenced this pull request Jul 24, 2019
…ree (GH-14867) (GH-14935)

* Fix the formatting in the documentation of the tostring() functions.

* bpo-34160: Document that the tostring() and tostringlist() functions also preserve the attribute order now.

* bpo-34160: Add an explanation of how users should deal with the attribute order.
(cherry picked from commit a3697db)

Co-authored-by: Stefan Behnel <stefan_ml@behnel.de>
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
…ythonGH-14867)

* Fix the formatting in the documentation of the tostring() functions.

* bpo-34160: Document that the tostring() and tostringlist() functions also preserve the attribute order now.

* bpo-34160: Add an explanation of how users should deal with the attribute order.
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
…ythonGH-14867)

* Fix the formatting in the documentation of the tostring() functions.

* bpo-34160: Document that the tostring() and tostringlist() functions also preserve the attribute order now.

* bpo-34160: Add an explanation of how users should deal with the attribute order.
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
…ythonGH-14867)

* Fix the formatting in the documentation of the tostring() functions.

* bpo-34160: Document that the tostring() and tostringlist() functions also preserve the attribute order now.

* bpo-34160: Add an explanation of how users should deal with the attribute order.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants