Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.8] Fix typos in docs, comments and test assert messages (GH-14872). #14900

Merged
merged 1 commit into from
Jul 22, 2019
Merged

[3.8] Fix typos in docs, comments and test assert messages (GH-14872). #14900

merged 1 commit into from
Jul 22, 2019

Conversation

aeros
Copy link
Contributor

@aeros aeros commented Jul 22, 2019

Original PR: #14872

(cherry picked from commit 96e12d5)

Co-authored-by: Min ho Kim minho42@gmail.com

@minho42 @aeros
[3.8] Fix typos in docs, comments and test assert messages (pythonGH-…
a6a0aa5 
…14872).

(cherry picked from commit 96e12d5)

Co-authored-by: Min ho Kim <minho42@gmail.com>
@bedevere-bot bedevere-bot mentioned this pull request Jul 22, 2019
Merged
@aeros
Copy link
Contributor Author

aeros commented Jul 22, 2019 •
edited
Loading

This is my first attempt at a manual backport, let me know if the title or anything else needs to be adjusted.

eamanu
eamanu reviewed Jul 22, 2019
View reviewed changes
Copy link
Contributor

@eamanu eamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@terryjreedy terryjreedy merged commit 24b5b36 into python:3.8 Jul 22, 2019
@bedevere-bot
Copy link

@terryjreedy: Please replace # with GH- in the commit message next time. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eamanu eamanu eamanu left review comments

@terryjreedy terryjreedy terryjreedy approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@ericvsmith ericvsmith Awaiting requested review from ericvsmith ericvsmith is a code owner

@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aeros @bedevere-bot @eamanu @terryjreedy @the-knights-who-say-ni @minho42