bpo-17535: IDLE: increase line number horizontal padding by 2 pixels #14959

taleinat · 2019-07-26T13:14:29Z

As suggested on the issue tracker, though I found that adding 2 pixels looks much nicer than adding just 1.

https://bugs.python.org/issue17535

terryjreedy · 2019-07-26T16:38:40Z

@aeros167
Kyle, the change is a single char, replacing 0 with something. I am undecided on whether I prefer 1 or 2. For me, the text has 2 pixel of padding on the left. padx=1 in the sidebar matches this on the right of the numbers; =2 exceeds it. Do you have a stronger opinion? To test, edit repository idlelib.sidebar in IDLE, change line 54, and run. When the htest box appears, after unittests, hit the button. Try changing the initial 'a' to 'M', in the first two lines, for a different visual effect. Revert to 0 when done.

terryjreedy · 2019-07-26T16:40:03Z

The Azure pipelines is a timeout failure of the Mac test. This happens on and off. Not related.

aeros

@taleinat Thanks for the PR, I definitely like the look horizontal padding of 2 better than before. However, I think 4 might be a slight further improvement. To compare the two, I did a side-by-side screenshot. The one on the left has a padding of 2 and the one on the right has a padding of 4:

Tested on Linux using a large font size of 29 with the Arial font style so that the gap is easier to compare between the two.

Since it's a bit subjective, it might be a bit difficult to "objectively" determine which one looks better, but I personally have a preference towards the one of the right with the horizontal padding of 4. Let me know what you think. I would definitely approve of the PR either way though (:

aeros · 2019-07-26T19:51:16Z

Lib/idlelib/sidebar.py

@@ -51,7 +51,7 @@ def __init__(self, editwin):

        _padx, pady = get_widget_padding(self.text)
        self.sidebar_text = tk.Text(self.parent, width=1, wrap=tk.NONE,
-                                    padx=0, pady=pady,
+                                    padx=2, pady=pady,


Suggested change

padx=2, pady=pady,

padx=4, pady=pady,

aeros · 2019-07-26T20:53:04Z

@terryjreedy If the mac tests are periodically timing out, would it be helpful to increase the timeout duration beyond the present 60 to something like 80? I'm not sure what that would involve, I don't have much experience with regards to modifying integration test settings or know where the CPython testing configuration file would be located.

Also, I did the review without reading the comments (besides the top one taleinat made), so I didn't see your instructions, my apologies. Would you like me to do another review following your instructions or is the one that I did adequate?

Between 1 and 2, I would lean towards two, but I personally have preference of padx=4. However, as I mentioned in the review, this might be quite subjective. I would consider any increase to be an improvement though.

terryjreedy · 2019-07-27T03:22:48Z

@aeros167 If there is not an issue for Mac tests timing out, and I would search first, there should be, with Victor Stinner and Steve Dower nosey. I suspect that the hung tests will not finish with 20 more minutes.

You images lack letters in the text for comparison. A total padding of 3 on the number side is already more than the total 2 on the text side. It may be the the absolute padding in real units (mm) should depend somewhat on the absolute height, in which case the pixel padding would depend on the pixels/inch or cm. At least in some places, numbers can be given with real units.

Right now, I am concerned with getting merges done for a3, scheduled Monday. So I am going to merge this as is. It is better than no change. Anything more sophisticated should be a new issue, not this closed one.

miss-islington · 2019-07-27T03:24:39Z

Thanks @taleinat for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington · 2019-07-27T03:24:40Z

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

…nGH-14959) (cherry picked from commit 46ebd4a) Co-authored-by: Tal Einat <taleinat@gmail.com>

bedevere-bot · 2019-07-27T03:24:59Z

GH-14973 is a backport of this pull request to the 3.7 branch.

miss-islington · 2019-07-27T03:25:01Z

Thanks @taleinat for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington · 2019-07-27T03:25:14Z

Thanks @taleinat for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

…nGH-14959) (cherry picked from commit 46ebd4a) Co-authored-by: Tal Einat <taleinat@gmail.com>

bedevere-bot · 2019-07-27T03:25:25Z

GH-14974 is a backport of this pull request to the 3.8 branch.

aeros · 2019-07-27T03:29:39Z

@terryjreedy Oh okay, that makes sense. Personally, I think just having line numbers in general is a huge improvement, and adding this change to slightly adjust the margin provides a significant improvement.

Also, with regards there not being letters, I was primarily referring to the gap between the line numbers and the dividing line in my feedback in the BPO issue, rather than the gap between the numbers and the letters. Apologies if I wasn't clear on that. Is that managed by a separate property?

) (cherry picked from commit 46ebd4a) Co-authored-by: Tal Einat <taleinat@gmail.com>

terryjreedy · 2019-07-27T03:51:26Z

I understand. I was saying that in my opinion, spacing should be looked at in context, with real text. But anyway, this is for a followup.

…nGH-14959)

increase line numbers horizontal padding by 2 pixels

ce80a56

taleinat added type-feature A feature request or enhancement skip news needs backport to 3.7 labels Jul 26, 2019

taleinat requested a review from terryjreedy July 26, 2019 13:14

the-knights-who-say-ni added the CLA signed label Jul 26, 2019

bedevere-bot added the awaiting core review label Jul 26, 2019

aeros approved these changes Jul 26, 2019

View reviewed changes

terryjreedy changed the title ~~bpo-17535: IDLE: increase line numbers horizontal padding by 2 pixels~~ bpo-17535: IDLE: increase line number horizontal padding by 2 pixels Jul 27, 2019

terryjreedy merged commit 46ebd4a into python:master Jul 27, 2019

bedevere-bot removed the awaiting core review label Jul 27, 2019

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 27, 2019

bpo-17535: Increase line number horizontal padding by 2 pixels (pytho…

96fa1c8

…nGH-14959) (cherry picked from commit 46ebd4a) Co-authored-by: Tal Einat <taleinat@gmail.com>

bedevere-bot removed the needs backport to 3.7 label Jul 27, 2019

terryjreedy added needs backport to 3.7 and removed needs backport to 3.8 labels Jul 27, 2019

terryjreedy added the needs backport to 3.8 label Jul 27, 2019

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 27, 2019

bpo-17535: Increase line number horizontal padding by 2 pixels (pytho…

f458737

…nGH-14959) (cherry picked from commit 46ebd4a) Co-authored-by: Tal Einat <taleinat@gmail.com>

bedevere-bot removed the needs backport to 3.8 label Jul 27, 2019

miss-islington added a commit that referenced this pull request Jul 27, 2019

bpo-17535: Increase line number horizontal padding by 2 pixels (GH-14959

9e7697b

) (cherry picked from commit 46ebd4a) Co-authored-by: Tal Einat <taleinat@gmail.com>

miss-islington added a commit that referenced this pull request Jul 27, 2019

bpo-17535: Increase line number horizontal padding by 2 pixels (GH-14959

f6ab188

) (cherry picked from commit 46ebd4a) Co-authored-by: Tal Einat <taleinat@gmail.com>

lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019

bpo-17535: Increase line number horizontal padding by 2 pixels (pytho…

9eac272

…nGH-14959)

DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020

bpo-17535: Increase line number horizontal padding by 2 pixels (pytho…

ec5b85b

…nGH-14959)

websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020

bpo-17535: Increase line number horizontal padding by 2 pixels (pytho…

c04570b

…nGH-14959)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bpo-17535: IDLE: increase line number horizontal padding by 2 pixels #14959

bpo-17535: IDLE: increase line number horizontal padding by 2 pixels #14959

taleinat commented Jul 26, 2019 •

edited

Loading

terryjreedy commented Jul 26, 2019

terryjreedy commented Jul 26, 2019

aeros left a comment •

edited

Loading

aeros Jul 26, 2019

aeros commented Jul 26, 2019 •

edited

Loading

terryjreedy commented Jul 27, 2019

miss-islington commented Jul 27, 2019

miss-islington commented Jul 27, 2019

bedevere-bot commented Jul 27, 2019

miss-islington commented Jul 27, 2019

miss-islington commented Jul 27, 2019

bedevere-bot commented Jul 27, 2019

aeros commented Jul 27, 2019 •

edited

Loading

terryjreedy commented Jul 27, 2019

bpo-17535: IDLE: increase line number horizontal padding by 2 pixels #14959

bpo-17535: IDLE: increase line number horizontal padding by 2 pixels #14959

Conversation

taleinat commented Jul 26, 2019 • edited Loading

terryjreedy commented Jul 26, 2019

terryjreedy commented Jul 26, 2019

aeros left a comment • edited Loading

Choose a reason for hiding this comment

aeros Jul 26, 2019

Choose a reason for hiding this comment

aeros commented Jul 26, 2019 • edited Loading

terryjreedy commented Jul 27, 2019

miss-islington commented Jul 27, 2019

miss-islington commented Jul 27, 2019

bedevere-bot commented Jul 27, 2019

miss-islington commented Jul 27, 2019

miss-islington commented Jul 27, 2019

bedevere-bot commented Jul 27, 2019

aeros commented Jul 27, 2019 • edited Loading

terryjreedy commented Jul 27, 2019

taleinat commented Jul 26, 2019 •

edited

Loading

aeros left a comment •

edited

Loading

aeros commented Jul 26, 2019 •

edited

Loading

aeros commented Jul 27, 2019 •

edited

Loading