Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-29553: Fixed ArgumentParses format_usage for mutually exclusive groups #14976

Merged
merged 3 commits into from
Aug 25, 2019
Merged

bpo-29553: Fixed ArgumentParses format_usage for mutually exclusive groups #14976

merged 3 commits into from
Aug 25, 2019

Conversation

flavianh
Copy link

@flavianh flavianh commented Jul 27, 2019 •
edited by bedevere-bot
Loading

Fix for https://bugs.python.org/issue29553

Recreation of #117, updated to current master

https://bugs.python.org/issue29553

@andrewnester
Fixed ArgumentParses format_usage for mutually exclusive groups.
e62cd6a 
Co-authored-by: Andrew Nester <andrew.nester.dev@gmail.com>
@flavianh flavianh mentioned this pull request Jul 27, 2019
Closed
@flavianh
Copy link
Author

flavianh commented Aug 2, 2019

Anyone available for a review? @brettcannon @berkerpeksag

@brettcannon
Copy link
Member

@flavianh I'm not clear as to why you specifically think I'm in a good position to review this PR?

@flavianh
Copy link
Author

flavianh commented Aug 5, 2019

@brettcannon I added you because you commented on the PR I'm recreating. Didn't notice that it was an automatic message. Do you know who could review it? It's been lingering for 9 days

@brettcannon
Copy link
Member

@flavianh don't know sorry. I would try pinging the issue on bugs.python.org, and if you don't get a review within a week of doing that then email python-dev.

@aeros aeros mentioned this pull request Aug 23, 2019
Closed
@berkerpeksag berkerpeksag merged commit da27d9b into python:master Aug 25, 2019
@miss-islington
Copy link
Contributor

Thanks @flavianh for the PR, and @berkerpeksag for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @flavianh and @berkerpeksag, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker da27d9b9dc44913ffee8f28d9638985eaaa03755 3.8

@bedevere-bot
Copy link

GH-15494 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 25, 2019
@miss-islington
bpo-29553: Fix ArgumentParser.format_usage() for mutually exclusive g…
cace43e 
…roups (pythonGH-14976)

Co-authored-by: Andrew Nester <andrew.nester.dev@gmail.com>
(cherry picked from commit da27d9b)

Co-authored-by: Flavian Hautbois <flavianh@sicara.com>
@berkerpeksag
Copy link
Member

Thanks!

@flavianh would you like to create a backport PR for 3.8?

berkerpeksag pushed a commit that referenced this pull request Aug 25, 2019
@miss-islington @berkerpeksag
bpo-29553: Fix ArgumentParser.format_usage() for mutually exclusive g…
31ea447 
…roups (GH-14976)

Co-authored-by: Andrew Nester <andrew.nester.dev@gmail.com>
Co-authored-by: Flavian Hautbois <flavianh@sicara.com>

(cherry picked from commit da27d9b)
rhettinger added a commit to rhettinger/cpython that referenced this pull request Aug 30, 2019
@rhettinger
[3.8] bpo-29553: Fix ArgumentParser.format_usage() for mutually exclu…
3852021 
…sive groups (pythonGH-14976) (pythonGH-15494)
rhettinger added a commit that referenced this pull request Aug 30, 2019
@rhettinger
[3.8] bpo-29553: Fix ArgumentParser.format_usage() for mutually exclu…
bd8ca9a 
…sive groups (GH-14976) (GH-15494) (GH-15624)
@berkerpeksag berkerpeksag mentioned this pull request Aug 31, 2019
Closed
@flavianh
Copy link
Author

flavianh commented Sep 2, 2019

@berkerpeksag Sure, how do I go about that?

lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@andrewnester @lisroach
bpo-29553: Fix ArgumentParser.format_usage() for mutually exclusive g…
6ffdad7 
…roups (pythonGH-14976)

Co-authored-by: Andrew Nester <andrew.nester.dev@gmail.com>
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@andrewnester @DinoV
bpo-29553: Fix ArgumentParser.format_usage() for mutually exclusive g…
d5b1399 
…roups (pythonGH-14976)

Co-authored-by: Andrew Nester <andrew.nester.dev@gmail.com>
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@andrewnester @websurfer5
bpo-29553: Fix ArgumentParser.format_usage() for mutually exclusive g…
2439169 
…roups (pythonGH-14976)

Co-authored-by: Andrew Nester <andrew.nester.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berkerpeksag berkerpeksag berkerpeksag approved these changes

Assignees

@berkerpeksag berkerpeksag

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@flavianh @brettcannon @miss-islington @bedevere-bot @berkerpeksag @the-knights-who-say-ni