Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-36311: Fixes decoding multibyte characters around chunk boundaries and improves decoding performance #15083

Merged
merged 3 commits into from
Aug 21, 2019

Conversation

zooba
Copy link
Member

@zooba zooba commented Aug 2, 2019

@zooba
Copy link
Member Author

zooba commented Aug 2, 2019

I also fixed the nearly-relevant bigmem test and added one that covers this case. Both pass - the new one would fail with WindowsError 87 without the unicodeobject fix.

@zooba zooba merged commit 7ebdda0 into python:master Aug 21, 2019
@zooba zooba deleted the bpo-36311 branch August 21, 2019 23:22
@miss-islington
Copy link
Contributor

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 21, 2019
…s and improves decoding performance (pythonGH-15083)

(cherry picked from commit 7ebdda0)

Co-authored-by: Steve Dower <steve.dower@python.org>
@bedevere-bot
Copy link

GH-15374 is a backport of this pull request to the 3.8 branch.

@bedevere-bot
Copy link

GH-15375 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 21, 2019
…s and improves decoding performance (pythonGH-15083)

(cherry picked from commit 7ebdda0)

Co-authored-by: Steve Dower <steve.dower@python.org>
@miss-islington
Copy link
Contributor

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @zooba, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 7ebdda0dbee7df6f0c945a7e1e623e47676e112d 2.7

@zooba zooba removed their assignment Aug 21, 2019
miss-islington added a commit that referenced this pull request Aug 21, 2019
…s and improves decoding performance (GH-15083)

(cherry picked from commit 7ebdda0)

Co-authored-by: Steve Dower <steve.dower@python.org>
miss-islington added a commit that referenced this pull request Aug 21, 2019
…s and improves decoding performance (GH-15083)

(cherry picked from commit 7ebdda0)

Co-authored-by: Steve Dower <steve.dower@python.org>
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants