Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-37681: no_sanitize_thread supported from gcc 5.1 #15096

Merged
merged 1 commit into from
Aug 14, 2019
Merged

bpo-37681: no_sanitize_thread supported from gcc 5.1 #15096

merged 1 commit into from
Aug 14, 2019

Conversation

shihai1991
Copy link
Member

@shihai1991 shihai1991 commented Aug 3, 2019 •
edited by bedevere-bot
Loading

@shihai1991
Copy link
Member Author

shihai1991 commented Aug 3, 2019 •
edited
Loading

cc @izbyshev @ronaldoussoren

@shihai1991
Copy link
Member Author

@vstinner Looks Ronald too busy, bothering you again.

@ronaldoussoren
Copy link
Contributor

The patch looks sane. My current plan is to spend tonight (CEST) on some CPython work including this PR.

@ronaldoussoren
Copy link
Contributor

One thing you could do is create a news entry (see the "Details" link at the failing pre-merge checks).

@vstinner vstinner merged commit 7e479c8 into python:master Aug 14, 2019
@miss-islington
Copy link
Contributor

Thanks @shihai1991 for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 14, 2019
@shihai1991 @miss-islington
bpo-37681: no_sanitize_thread support from GCC 5.1 (pythonGH-15096)
c6c48bf 
Fix the following warning with GCC 4.8.5:
Objects/obmalloc.c: warning: ‘no_sanitize_thread’ attribute directive ignored
(cherry picked from commit 7e479c8)

Co-authored-by: Hai Shi <shihai1992@gmail.com>
@bedevere-bot
Copy link

GH-15270 is a backport of this pull request to the 3.8 branch.

@bedevere-bot
Copy link

GH-15271 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 14, 2019
@shihai1991 @miss-islington
bpo-37681: no_sanitize_thread support from GCC 5.1 (pythonGH-15096)
4a905b0 
Fix the following warning with GCC 4.8.5:
Objects/obmalloc.c: warning: ‘no_sanitize_thread’ attribute directive ignored
(cherry picked from commit 7e479c8)

Co-authored-by: Hai Shi <shihai1992@gmail.com>
miss-islington added a commit that referenced this pull request Aug 14, 2019
@miss-islington @shihai1991
bpo-37681: no_sanitize_thread support from GCC 5.1 (GH-15096)
364a1d3 
Fix the following warning with GCC 4.8.5:
Objects/obmalloc.c: warning: ‘no_sanitize_thread’ attribute directive ignored
(cherry picked from commit 7e479c8)

Co-authored-by: Hai Shi <shihai1992@gmail.com>
miss-islington added a commit that referenced this pull request Aug 14, 2019
@miss-islington @shihai1991
bpo-37681: no_sanitize_thread support from GCC 5.1 (GH-15096)
15b6d0a 
Fix the following warning with GCC 4.8.5:
Objects/obmalloc.c: warning: ‘no_sanitize_thread’ attribute directive ignored
(cherry picked from commit 7e479c8)

Co-authored-by: Hai Shi <shihai1992@gmail.com>
@shihai1991
Copy link
Member Author

The patch looks sane. My current plan is to spend tonight (CEST) on some CPython work including this PR.

copy that. Thanks, guys:)

@vstinner
Copy link
Member

@ronaldoussoren: "The patch looks sane. My current plan is to spend tonight (CEST) on some CPython work including this PR."

Oh sorry, I missed your comment and went ahead: I merged the PR.

@ronaldoussoren: "One thing you could do is create a news entry (see the "Details" link at the failing pre-merge checks)."

I consider that changes which only fix compiler warnings don't deserve a NEWS entry, so I added "skip news" label.

lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@shihai1991 @lisroach
bpo-37681: no_sanitize_thread support from GCC 5.1 (pythonGH-15096)
0df1d4c 
Fix the following warning with GCC 4.8.5:
Objects/obmalloc.c: warning: ‘no_sanitize_thread’ attribute directive ignored
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@shihai1991 @DinoV
bpo-37681: no_sanitize_thread support from GCC 5.1 (pythonGH-15096)
4c03676 
Fix the following warning with GCC 4.8.5:
Objects/obmalloc.c: warning: ‘no_sanitize_thread’ attribute directive ignored
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@shihai1991 @websurfer5
bpo-37681: no_sanitize_thread support from GCC 5.1 (pythonGH-15096)
de9c075 
Fix the following warning with GCC 4.8.5:
Objects/obmalloc.c: warning: ‘no_sanitize_thread’ attribute directive ignored
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shihai1991 @ronaldoussoren @miss-islington @bedevere-bot @vstinner @the-knights-who-say-ni