-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-37681: no_sanitize_thread supported from gcc 5.1 #15096
Conversation
@vstinner Looks Ronald too busy, bothering you again. |
The patch looks sane. My current plan is to spend tonight (CEST) on some CPython work including this PR. |
One thing you could do is create a news entry (see the "Details" link at the failing pre-merge checks). |
Thanks @shihai1991 for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
Fix the following warning with GCC 4.8.5: Objects/obmalloc.c: warning: ‘no_sanitize_thread’ attribute directive ignored (cherry picked from commit 7e479c8) Co-authored-by: Hai Shi <shihai1992@gmail.com>
GH-15270 is a backport of this pull request to the 3.8 branch. |
GH-15271 is a backport of this pull request to the 3.7 branch. |
Fix the following warning with GCC 4.8.5: Objects/obmalloc.c: warning: ‘no_sanitize_thread’ attribute directive ignored (cherry picked from commit 7e479c8) Co-authored-by: Hai Shi <shihai1992@gmail.com>
copy that. Thanks, guys:) |
@ronaldoussoren: "The patch looks sane. My current plan is to spend tonight (CEST) on some CPython work including this PR." Oh sorry, I missed your comment and went ahead: I merged the PR. @ronaldoussoren: "One thing you could do is create a news entry (see the "Details" link at the failing pre-merge checks)." I consider that changes which only fix compiler warnings don't deserve a NEWS entry, so I added "skip news" label. |
Fix the following warning with GCC 4.8.5: Objects/obmalloc.c: warning: ‘no_sanitize_thread’ attribute directive ignored
Fix the following warning with GCC 4.8.5: Objects/obmalloc.c: warning: ‘no_sanitize_thread’ attribute directive ignored
Fix the following warning with GCC 4.8.5: Objects/obmalloc.c: warning: ‘no_sanitize_thread’ attribute directive ignored
https://bugs.python.org/issue37681