Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.7] bpo-1967: proxy dictviews in dictproxy #15143

Closed
wants to merge 1 commit into from

Conversation

graingert
Copy link
Contributor

@graingert graingert commented Aug 6, 2019

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@jdemeyer
Copy link
Contributor

jdemeyer commented Aug 6, 2019

The title should start with [2.7] to make it clear that this is for 2.7 only.

@graingert graingert changed the title bpo-1967: proxy dictviews in dictproxy [2.7] bpo-1967: proxy dictviews in dictproxy Aug 6, 2019
@vstinner
Copy link
Member

People survived without these 3 methods. It's too late to "complete" Python 2.7: it will no longer be supported in 6 months. I close this PR.

@vstinner vstinner closed this Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants