Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-36511 fix failures in Windows Python arm32 buildbot tests #15181

Merged
merged 2 commits into from
Aug 8, 2019

Conversation

paulmon
Copy link
Contributor

@paulmon paulmon commented Aug 8, 2019

@zooba, @zware

win_utils.py: If an exception is thrown during WindowsLoadTracker creation, which is expected on Windows ARM32, then when WindowsLoadTracker.close( ) is called then self.p is not defined. This change ensures that self.p is always initialized.

test_compile.py: test_stack_overflow throws a MemoryException randomly on Windows arm32. I believe this test is running out of memory because the arm32 test hardware only has 1 GB of RAM. What is the best way to fix this? Is handling the MemoryException ok? or does that cover up a real problem?

remoteDeploy.bat: the files in the Parser directory are needed to prevent warnings when running test_asdl_parser.

Please let me know if I should split this into multiple PRs or create new issue(s).

Thanks,
Paul

https://bugs.python.org/issue36511

@zooba
Copy link
Member

zooba commented Aug 8, 2019

The MemoryError might be hiding something else, unless it's because of the string generation. In which case, I'd separate that out from the compile call.

@paulmon
Copy link
Contributor Author

paulmon commented Aug 8, 2019

The string generation didn't cause a MemoryError.
Undoing suppressing the exception.

@zooba zooba merged commit ed70a34 into python:master Aug 8, 2019
@miss-islington
Copy link
Contributor

Thanks @paulmon for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

@miss-islington
Copy link
Contributor

Thanks @paulmon for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 8, 2019
(cherry picked from commit ed70a34)

Co-authored-by: Paul Monson <paulmon@users.noreply.github.com>
@bedevere-bot
Copy link

GH-15186 is a backport of this pull request to the 3.8 branch.

@paulmon paulmon deleted the fix_arm32_buildbot branch August 12, 2019 20:06
vstinner added a commit that referenced this pull request Aug 14, 2019
…-15279)

* bpo-37531: Fix regrtest timeout for subprocesses (GH-15072)

Co-Authored-By: Joannah Nanjekye <joannah.nanjekye@ibm.com>
(cherry picked from commit b0c8369)

* bpo-36511: Fix failures in Windows ARM32 buildbot (GH-15181)

(cherry picked from commit ed70a34)

Backport also minor fixes from master (fix typo, remove importlib import).
@miss-islington
Copy link
Contributor

Thanks @paulmon for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

@miss-islington
Copy link
Contributor

Thanks @paulmon for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 29, 2019
(cherry picked from commit ed70a34)

Co-authored-by: Paul Monson <paulmon@users.noreply.github.com>
@bedevere-bot
Copy link

GH-15571 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Aug 29, 2019
(cherry picked from commit ed70a34)

Co-authored-by: Paul Monson <paulmon@users.noreply.github.com>
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@paulmon paulmon mannequin mentioned this pull request May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants