Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs for assert_called and assert_called_once #15197

Merged
merged 1 commit into from
Aug 12, 2019

Conversation

ismail-s
Copy link
Contributor

The code that this part of the docs documents is:

def assert_called(self):
"""assert that the mock was called at least once
"""
if self.call_count == 0:
msg = ("Expected '%s' to have been called." %
self._mock_name or 'mock')
raise AssertionError(msg)
def assert_called_once(self):

Copy link
Member

@tirkarthi tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for catching this. cc: @cjw296 @mariocj89

@bedevere-bot
Copy link

@cjw296: Please replace # with GH- in the commit message next time. Thanks!

@tirkarthi
Copy link
Member

@cjw296 Could this be backported to 3.8 and 3.7 since this is a doc fix? @miss-islington will take care of it as labels are added. Thanks for the merge :)

@miss-islington
Copy link
Contributor

Thanks @ismail-s for the PR, and @cjw296 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

Thanks @ismail-s for the PR, and @cjw296 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

@bedevere-bot
Copy link

GH-15218 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 12, 2019
(cherry picked from commit f9590ed)

Co-authored-by: Ismail S <ismail-s@users.noreply.github.com>
@miss-islington
Copy link
Contributor

Thanks @ismail-s for the PR, and @cjw296 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 12, 2019
(cherry picked from commit f9590ed)

Co-authored-by: Ismail S <ismail-s@users.noreply.github.com>
@bedevere-bot
Copy link

GH-15219 is a backport of this pull request to the 3.8 branch.

lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants